Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add whitespace trimming test with copyright symbol #147

Merged
merged 4 commits into from Oct 17, 2019
Merged

Add whitespace trimming test with copyright symbol #147

merged 4 commits into from Oct 17, 2019

Conversation

MaxDesiatov
Copy link
Collaborator

Resolve #141

@MaxDesiatov MaxDesiatov mentioned this pull request Oct 17, 2019
Closed
@codecov
Copy link

codecov bot commented Oct 17, 2019 •
edited

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   72.17%   72.17%           
=======================================
  Files          43       43           
  Lines        2401     2401           
=======================================
  Hits         1733     1733           
  Misses        668      668

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f76263...1b845c7. Read the comment docs.

@MaxDesiatov MaxDesiatov mentioned this pull request Oct 17, 2019
Closed
@hodovani hodovani assigned MaxDesiatov and unassigned hodovani Oct 17, 2019
@MaxDesiatov MaxDesiatov assigned hodovani and unassigned MaxDesiatov Oct 17, 2019
@hodovani hodovani assigned MaxDesiatov and hodovani and unassigned hodovani and MaxDesiatov Oct 17, 2019
hodovani
hodovani approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@hodovani hodovani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaxDesiatov thank you 👍

@MaxDesiatov MaxDesiatov merged commit c1bd6f1 into master Oct 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the copyright-space branch October 17, 2019 13:22
arjungupta0107 pushed a commit to salido/XMLCoder that referenced this pull request Jun 26, 2020
@MaxDesiatov
Add whitespace trimming test with copyright symbol (CoreOffice#147)
138fb7d 
Resolve CoreOffice#141.

* Example of wrong whitespace trimming when copyright symbol is present
* Set decoder.trimValueWhitespaces to false in test
* Move repeated string to constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodovani hodovani hodovani approved these changes

Assignees

@hodovani hodovani

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MaxDesiatov @hodovani @DJBen