Support for mixed-content nodes #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 17, 2019
ultramiraculous
force-pushed
the
mixed-content
branch
from
bdd074c
to
df68c01
Compare
houndci-bot
reviewed
Dec 17, 2019
ultramiraculous
force-pushed
the
mixed-content
branch
from
df68c01
to
d65fd7a
Compare
ultramiraculous
force-pushed
the
mixed-content
branch
from
d65fd7a
to
6de0862
Compare
MaxDesiatov
approved these changes
Dec 17, 2019
|
For some reason Azure Pipelines status is not reported to GitHub now, but the CI job has passed. I assume the issue with this is intermittent and going to merge it as is. |
arjungupta0107
pushed a commit
to salido/XMLCoder
that referenced
this pull request
Jun 26, 2020
Adding support for nodes with mixed content, where loose text nodes might coexist with other node types. An example of this in the tests is: `<container>first<b>bold text</b>second</container>`. This restructures the contents of nodes, so that raw text is always stored in a `""`-keyed node, which can occur multiple times if necessary. Previously all text nodes were appended together into the element's `value`, so their order relative to elements between them was lost. * Support for mixed-content node contents * Attempt at avoiding force cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for nodes with mixed content, where loose text nodes might coexist with other node types. An example of this in the tests is:
<container>first<b>bold text</b>second</container>.This restructures the contents of nodes, so that raw text is always stored in a
""-keyed node, which can occur multiple times if necessary. Previously all text nodes were appended together into the element'svalue, so their order relative to elements between them was lost.