Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Danger with GitHub Actions #163

Merged
merged 9 commits into from Mar 22, 2020
Merged

Run Danger with GitHub Actions #163

merged 9 commits into from Mar 22, 2020

Conversation

MaxDesiatov
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #163 into master will decrease coverage by 0.4%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   72.93%   72.52%   -0.41%     
==========================================
  Files          43       43              
  Lines        2457     2264     -193     
==========================================
- Hits         1792     1642     -150     
+ Misses        665      622      -43
Impacted Files Coverage Δ
...es/XMLCoder/Decoder/XMLDecoderImplementation.swift 67.35% <100%> (-1.86%) ⬇️
...s/XMLCoder/Encoder/XMLKeyedEncodingContainer.swift 71.65% <100%> (-0.29%) ⬇️
...s/XMLCoder/Decoder/XMLKeyedDecodingContainer.swift 80.66% <100%> (-2.4%) ⬇️
...XMLCoder/Decoder/XMLUnkeyedDecodingContainer.swift 36.49% <50%> (+0.19%) ⬆️
Sources/XMLCoder/Auxiliaries/Box/DoubleBox.swift 60% <0%> (-6.67%) ⬇️
Sources/XMLCoder/Decoder/XMLDecoder.swift 75.19% <0%> (-2.43%) ⬇️
Sources/XMLCoder/Auxiliaries/XMLStackParser.swift 93.61% <0%> (-0.88%) ⬇️
Sources/XMLCoder/Encoder/XMLEncoder.swift 83.16% <0%> (-0.62%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6a0f0...e4ac62c. Read the comment docs.

Dangerfile.swift Outdated Show resolved Hide resolved
Use XMLEncoder.NonConformingFloatEncodingStrategy.convertToString \
to specify how the value should be encoded.
"""
let debugDescription = "Unable to encode \(valueDescription) directly in XML. Use XMLEncoder.NonConformingFloatEncodingStrategy.convertToString to specify how the value should be encoded."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line Length Violation: Line should be 150 characters or less: currently 196 characters (line_length)

@github-actions
Copy link

Fails
🚫

Sources/XMLCoder/Decoder/XMLDecoderImplementation.swift#L196 - Function should have complexity 10 or less: currently complexity equals 11 (cyclomatic_complexity)

🚫

Sources/XMLCoder/Decoder/XMLDecoderImplementation.swift#L493 - File should contain 400 lines or less: currently contains 493 (file_length)

🚫

Sources/XMLCoder/Decoder/XMLKeyedDecodingContainer.swift#L226 - Function body should span 50 lines or less excluding comments and whitespace: currently spans 75 lines (function_body_length)

🚫

Sources/XMLCoder/Decoder/XMLKeyedDecodingContainer.swift#L226 - Function should have complexity 10 or less: currently complexity equals 14 (cyclomatic_complexity)

Generated by 🚫 Danger Swift against e4ac62c

@MaxDesiatov MaxDesiatov marked this pull request as ready for review March 22, 2020 19:28
@MaxDesiatov MaxDesiatov merged commit c553718 into master Mar 22, 2020
@MaxDesiatov MaxDesiatov deleted the danger-ci branch March 22, 2020 19:28
arjungupta0107 pushed a commit to salido/XMLCoder that referenced this pull request Jun 26, 2020
* Run Danger with GitHub Actions

* Add Dangerfile.swift, GitHub token to main.yml

* Add newline to Dangerfile.swift

* Set latest version of Danger in main.yml

* Attempt to use forked danger-swift with Swiftlint

* Test inline linter warnings

* Revert "Test inline linter warnings"

This reverts commit 7f863be.

* Avoid installing and running SwiftLint on Azure

* Fix formatter issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants