Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode only strings as CDATA #179

Merged
merged 3 commits into from May 3, 2020
Merged

Encode only strings as CDATA #179

merged 3 commits into from May 3, 2020

Conversation

MaxDesiatov
Copy link
Collaborator

Fix #178

@MaxDesiatov MaxDesiatov added the bug Something isn't working label May 2, 2020
@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #179 into master will increase coverage by 0.19%.
The diff coverage is 92.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   73.12%   73.32%   +0.19%     
==========================================
  Files          43       43              
  Lines        2311     2332      +21     
==========================================
+ Hits         1690     1710      +20     
- Misses        621      622       +1     
Impacted Files Coverage Δ
Sources/XMLCoder/Auxiliaries/XMLCoderElement.swift 95.32% <88.09%> (-0.24%) ⬇️
Sources/XMLCoder/Encoder/XMLEncoder.swift 85.40% <100.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e6c56...620e9ef. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit 1f0e5de into master May 3, 2020
@MaxDesiatov MaxDesiatov deleted the cdata-fix branch May 3, 2020 10:04
arjungupta0107 pushed a commit to salido/XMLCoder that referenced this pull request Jun 26, 2020
* Encode only strings as CDATA

* Fix parameter renaming error

* Improve line count in XMLEncoder.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-string values are being encoded as CData when stringEncodingStrategy = .cdata
1 participant