Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettyPrintIndentation property on XMLEncoder #186

Merged
merged 3 commits into from May 31, 2020

Conversation

MaxDesiatov
Copy link
Collaborator

New property can take XMLEncoder.PrettyPrintIndentation values such as .tabs(1) or .spaces(2).

Resolve #183.

@MaxDesiatov MaxDesiatov added the enhancement New feature or request label May 31, 2020
@github-actions
Copy link

github-actions bot commented May 31, 2020

Fails
🚫

Error deserializing SwiftLint JSON response (): dataCorrupted(Swift.DecodingError.Context(codingPath: [], debugDescription: "The given data was not valid JSON.", underlyingError: Optional(Error Domain=NSCocoaErrorDomain Code=3840 "The data is not in the correct format.")))

Generated by 🚫 Danger Swift against e9b2bdd

@codecov
Copy link

codecov bot commented May 31, 2020

Codecov Report

Merging #186 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   73.32%   73.52%   +0.19%     
==========================================
  Files          43       43              
  Lines        2332     2342      +10     
==========================================
+ Hits         1710     1722      +12     
+ Misses        622      620       -2     
Impacted Files Coverage Δ
Sources/XMLCoder/Auxiliaries/XMLCoderElement.swift 96.36% <100.00%> (+1.03%) ⬆️
Sources/XMLCoder/Encoder/XMLEncoder.swift 86.01% <100.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 388ba82...e9b2bdd. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit 0d1c1b9 into master May 31, 2020
@MaxDesiatov MaxDesiatov deleted the configurable-pretty-printing branch May 31, 2020 19:00
arjungupta0107 pushed a commit to salido/XMLCoder that referenced this pull request Jun 26, 2020
New property can take `XMLEncoder.PrettyPrintIndentation` values such as `.tabs(1)` or `.spaces(2)`.

Resolve CoreOffice#183.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use 2 spaces instead of 4 when .prettyPrinted
1 participant