Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make character escaping customizable in XMLEncoder #188

Merged
merged 7 commits into from Jun 1, 2020
Merged

Make character escaping customizable in XMLEncoder #188

merged 7 commits into from Jun 1, 2020

Conversation

MaxDesiatov
Copy link
Collaborator

Resolve #185.
Resolve #187.

Add new charactersEscapedInAttributes and charactersEscapedInElements properties on XMLEncoder that allow customizing how certain characters are escaped.

@MaxDesiatov MaxDesiatov added the enhancement New feature or request label Jun 1, 2020
@github-actions
Copy link

github-actions bot commented Jun 1, 2020 •
edited

Fails
🚫

Error deserializing SwiftLint JSON response (): dataCorrupted(Swift.DecodingError.Context(codingPath: [], debugDescription: "The given data was not valid JSON.", underlyingError: Optional(Error Domain=NSCocoaErrorDomain Code=3840 "The data is not in the correct format.")))

Generated by 🚫 Danger Swift against 4fef6fb

@codecov
Copy link

codecov bot commented Jun 1, 2020 •
edited

Codecov Report

Merging #188 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   73.52%   73.71%   +0.19%     
==========================================
  Files          43       43              
  Lines        2342     2359      +17     
==========================================
+ Hits         1722     1739      +17     
  Misses        620      620
Impacted Files Coverage Δ
Sources/XMLCoder/Auxiliaries/XMLCoderElement.swift 96.34% <100.00%> (-0.02%) ⬇️
Sources/XMLCoder/Encoder/XMLEncoder.swift 87.57% <100.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d1c1b9...4fef6fb. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit d502e63 into master Jun 1, 2020
@MaxDesiatov MaxDesiatov deleted the configure-character-escapes branch June 1, 2020 19:14
arjungupta0107 pushed a commit to salido/XMLCoder that referenced this pull request Jun 26, 2020
@MaxDesiatov
Make character escaping customizable in XMLEncoder (CoreOffice#188)
4524c24 
Resolve CoreOffice#185.
Resolve CoreOffice#187.

Add new `charactersEscapedInAttributes` and `charactersEscapedInElements` properties on `XMLEncoder` that allow customizing how certain characters are escaped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

" in XML element may not always be escaping &#10; in XML attributes
1 participant
@MaxDesiatov