Add convert from UPPERCASE decoding key strategy #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will convert from ALL_CAPS_SNAKE_CASE to camelCase. Previously, there was only snake_case, kebab-case, and first-letter-only Capitalised. To do ALL_CAPS, one would need to have used a custom key decoding strategy.
Codecov Report
@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 73.50% 73.62% +0.12%
==========================================
Files 46 46
Lines 2404 2408 +4
==========================================
+ Hits 1767 1773 +6
+ Misses 637 635 -2
Continue to review full report at Codecov.
|
MaxDesiatov
reviewed
Jul 29, 2021
MaxDesiatov
approved these changes
Jul 29, 2021
spotlightishere
pushed a commit
to WiiLink24/XMLCoder
that referenced
this pull request
Aug 6, 2021
* Add convert from UPPERCASE decoding key strategy This will convert from ALL_CAPS_SNAKE_CASE to camelCase. Previously, there was only snake_case, kebab-case, and first-letter-only Capitalised. To do ALL_CAPS, one would need to have used a custom key decoding strategy. * Update Tests/XMLCoderTests/Minimal/KeyedTests.swift Co-authored-by: Max Desiatov <max@desiatov.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will convert from
ALL_CAPS_SNAKE_CASEtocamelCase.Previously, there was only snake_case, kebab-case, and first-letter-only Capitalised. To do ALL_CAPS, one needed to use a custom key decoding strategy.
I've been using this to make a decoder for BeerXML, which tends to have the keys capitalised.