Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded parameter key #225

Merged
merged 1 commit into from Aug 14, 2021

Conversation

MartinP7r
Copy link
Contributor

The parameter was not used inside the method and only had one call-site

Please ignore if you are planning to use the parameter in some way.

All tests are passing

The parameter was not used inside the method and only had one call-site
@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #225 (c802db7) into main (887de88) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage   73.94%   73.94%           
=======================================
  Files          46       46           
  Lines        2437     2437           
=======================================
  Hits         1802     1802           
  Misses        635      635           
Impacted Files Coverage Δ
Sources/XMLCoder/Auxiliaries/XMLCoderElement.swift 96.49% <100.00%> (ø)
Sources/XMLCoder/Auxiliaries/XMLStackParser.swift 93.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 887de88...c802db7. Read the comment docs.

Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit

@MaxDesiatov MaxDesiatov merged commit a98fc76 into CoreOffice:main Aug 14, 2021
@MartinP7r
Copy link
Contributor Author

Thank you!

Any idea what the intention behind the parameter was in the first place?

@MaxDesiatov
Copy link
Collaborator

Thanks for the contribution! I wouldn't remember at this point. It could've been introduced accidentally, or it could be something vestigial and lost its purpose after some refactoring. The main thing is that it's now cleaned up 🙂

@MartinP7r MartinP7r deleted the remove_unnecessary_param branch August 17, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants