Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some of the swiftlint generated warnings #229

Merged
merged 1 commit into from Sep 11, 2021

Conversation

MartinP7r
Copy link
Contributor

This PR tends to some of the warnings generated by swiftlint.

Please feel free to adjust if the changes don't work for you.

The FIXME on the test values in StringTests.swift:19 seems to actually be fixed somehow because the tests are passing without any adjustment.

The FIXME on the test values in StringTests.swift:19 seems to actually be fixed somehow.
The tests are passing.
@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #229 (c8a0f83) into main (887de88) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   73.94%   74.00%   +0.06%     
==========================================
  Files          46       46              
  Lines        2437     2443       +6     
==========================================
+ Hits         1802     1808       +6     
  Misses        635      635              
Impacted Files Coverage Δ
Sources/XMLCoder/Auxiliaries/XMLStackParser.swift 94.05% <ø> (+0.12%) ⬆️
...rces/XMLCoder/Decoder/DecodingErrorExtension.swift 68.00% <ø> (ø)
Sources/XMLCoder/Decoder/XMLDecoder.swift 78.72% <ø> (ø)
Sources/XMLCoder/Auxiliaries/XMLCoderElement.swift 96.55% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 887de88...c8a0f83. Read the comment docs.

Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@MaxDesiatov MaxDesiatov merged commit de979e9 into CoreOffice:main Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants