Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up XMLElement, ArrayBox & DictionaryBox #28

Merged
merged 5 commits into from Dec 21, 2018
Merged

Clean up XMLElement, ArrayBox & DictionaryBox #28

merged 5 commits into from Dec 21, 2018

Conversation

regexident
Copy link
Contributor

@regexident regexident commented Dec 21, 2018

Depends on #26 & #27. Not anymore.

This is a first attempt at making _XMLElement more approachable.

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #28 into master will increase coverage by 0.26%.
The diff coverage is 75.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   51.31%   51.57%   +0.26%     
==========================================
  Files          29       29              
  Lines        1374     1400      +26     
==========================================
+ Hits          705      722      +17     
- Misses        669      678       +9
Impacted Files Coverage Δ
...urces/XMLCoder/Encoder/XMLReferencingEncoder.swift 0% <0%> (ø) ⬆️
...s/XMLCoder/Encoder/XMLKeyedEncodingContainer.swift 42.16% <0%> (ø) ⬆️
Sources/XMLCoder/Auxiliaries/XMLStackParser.swift 86.53% <100%> (+2.6%) ⬆️
Sources/XMLCoder/Decoder/XMLDecoder.swift 39.69% <100%> (ø) ⬆️
Sources/XMLCoder/Encoder/XMLEncoder.swift 48.21% <50%> (ø) ⬆️
Sources/XMLCoder/Box/UnkeyedBox.swift 57.14% <50%> (ø) ⬆️
...s/XMLCoder/Decoder/XMLKeyedDecodingContainer.swift 38.77% <58.06%> (+3.16%) ⬆️
Sources/XMLCoder/Box/KeyedBox.swift 77.27% <75.6%> (+3.07%) ⬆️
Sources/XMLCoder/Auxiliaries/XMLElement.swift 87.12% <82.05%> (-2.88%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d12f39e...7412933. Read the comment docs.

@regexident regexident changed the title Clean up XMLElement, ArrayBox & DictionaryBox [WIP] Clean up XMLElement, ArrayBox & DictionaryBox Dec 21, 2018
@regexident
Copy link
Contributor Author

@regexident
Copy link
Contributor Author

@regexident regexident changed the title [WIP] Clean up XMLElement, ArrayBox & DictionaryBox Clean up XMLElement, ArrayBox & DictionaryBox Dec 21, 2018
@regexident
Copy link
Contributor Author

regexident commented Dec 21, 2018

Should be ready to merge now. 🙂

Try to merge #27 first.
(Looks like I somehow rebased on that one. Unintentionally. Again. 🙄)

@MaxDesiatov MaxDesiatov merged commit 1f0cb9d into CoreOffice:master Dec 21, 2018
@regexident regexident deleted the fix/cleanup-xmlelement branch December 21, 2018 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants