Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted URL coding logic into URLBox with corresponding unit tests #30

Merged
merged 2 commits into from Dec 21, 2018
Merged

Extracted URL coding logic into URLBox with corresponding unit tests #30

merged 2 commits into from Dec 21, 2018

Conversation

regexident
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #30 into master will increase coverage by 0.75%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   50.55%   51.31%   +0.75%     
==========================================
  Files          28       29       +1     
  Lines        1351     1374      +23     
==========================================
+ Hits          683      705      +22     
- Misses        668      669       +1
Impacted Files Coverage Δ
Sources/XMLCoder/Encoder/XMLEncoder.swift 48.21% <100%> (+1.51%) ⬆️
Sources/XMLCoder/Decoder/XMLDecoder.swift 39.69% <66.66%> (+1.77%) ⬆️
Sources/XMLCoder/Box/URLBox.swift 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6a7233...17832a5. Read the comment docs.

@regexident
Copy link
Contributor Author

Rebased. Ready to merge.

MaxDesiatov
MaxDesiatov previously approved these changes Dec 21, 2018
MaxDesiatov
MaxDesiatov previously approved these changes Dec 21, 2018
@MaxDesiatov MaxDesiatov merged commit d12f39e into CoreOffice:master Dec 21, 2018
@regexident regexident deleted the feature/url-box branch December 21, 2018 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants