Fixed a bug that would cause XMLEncoder to throw on Encodables encoding nothing
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
=======================================
Coverage 51.57% 51.57%
=======================================
Files 29 29
Lines 1400 1400
=======================================
Hits 722 722
Misses 678 678
Continue to review full report at Codecov.
|
|
@regexident we got an intermittent problem with force-pushing to the same branch, but I think I got it fixed now, sorry about that. |
MaxDesiatov
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By encoding via
func encode(_:withRootKey:header:)we always get an XML root node with labelrootKey, so not encoding anything withinfunc encode(to:)is fine in XML (unlike JSON).