Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply SwiftFormat on CI runs #32

Merged
merged 2 commits into from Dec 22, 2018
Merged

Apply SwiftFormat on CI runs #32

merged 2 commits into from Dec 22, 2018

Conversation

MaxDesiatov
Copy link
Collaborator

We currently have a plenty of formatting issues such as inconsistent indentation, trailing whitespaces etc in the codebase. In addition, formatting-related coding style approaches are not enforced. Here latest changes from SwiftFormat are applied and in addition it is set up to execute checks on CI.

@MaxDesiatov MaxDesiatov self-assigned this Dec 22, 2018
@MaxDesiatov MaxDesiatov assigned hodovani and unassigned MaxDesiatov Dec 22, 2018
@MaxDesiatov MaxDesiatov removed the request for review from hodovani December 22, 2018 08:12
@codecov
Copy link

codecov bot commented Dec 22, 2018

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is 46.58%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   51.57%   51.57%           
=======================================
  Files          29       29           
  Lines        1400     1400           
=======================================
  Hits          722      722           
  Misses        678      678
Impacted Files Coverage Δ
Sources/XMLCoder/Box/NullBox.swift 33.33% <0%> (ø) ⬆️
Sources/XMLCoder/Auxiliaries/XMLStackParser.swift 86.53% <100%> (ø) ⬆️
Sources/XMLCoder/Box/FloatBox.swift 90% <100%> (ø) ⬆️
...urces/XMLCoder/Auxiliaries/String+Extensions.swift 100% <100%> (ø) ⬆️
Sources/XMLCoder/Encoder/XMLEncoder.swift 48.21% <100%> (ø) ⬆️
Sources/XMLCoder/Box/BoolBox.swift 86.66% <100%> (ø) ⬆️
Sources/XMLCoder/Box/DateBox.swift 91.48% <100%> (ø) ⬆️
Sources/XMLCoder/Box/IntBox.swift 85.71% <100%> (ø) ⬆️
Sources/XMLCoder/Box/DecimalBox.swift 85.71% <100%> (ø) ⬆️
Sources/XMLCoder/Box/StringBox.swift 100% <100%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 099272e...6b39aa4. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit 7b3c172 into master Dec 22, 2018
@delete-merged-branch delete-merged-branch bot deleted the formatting-ci branch December 22, 2018 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants