Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let compiler synthesize Equatable conformance for _XMLElement #33

Merged
merged 2 commits into from Dec 22, 2018

Conversation

jsbean
Copy link
Contributor

@jsbean jsbean commented Dec 22, 2018

As _XMLElement was made a struct in 1f0cb9d, we can let the compiler synthesize Equatable conformance for free.

This PR removes the custom _XMLElement: Equatable conformance implementation.

@jsbean
Copy link
Contributor Author

jsbean commented Dec 22, 2018

Ah, so SwiftFormat does not like the empty : Equatable { } notation. Otherwise, the tests pass.

Would you prefer the conformance to be placed up top (struct _XMLElement: Equatable {) or in some other fashion?

It looks like I misunderstood the rule (emptyBraces). Should be acceptable as of 0d75c10.

@codecov
Copy link

codecov bot commented Dec 22, 2018

Codecov Report

Merging #33 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   51.57%   51.32%   -0.25%     
==========================================
  Files          29       29              
  Lines        1400     1391       -9     
==========================================
- Hits          722      714       -8     
+ Misses        678      677       -1
Impacted Files Coverage Δ
Sources/XMLCoder/Auxiliaries/XMLElement.swift 86.99% <ø> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3c172...0d75c10. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit 231a0d6 into CoreOffice:master Dec 22, 2018
@jsbean jsbean deleted the xmlelement-equatable branch July 11, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants