Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfold guard … else blocks to allow for setting of breakpoints within #39

Merged
merged 1 commit into from Dec 23, 2018
Merged

Conversation

regexident
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 23, 2018

Codecov Report

Merging #39 into master will decrease coverage by 0.29%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #39     +/-   ##
=========================================
- Coverage   51.32%   51.03%   -0.3%     
=========================================
  Files          29       29             
  Lines        1391     1399      +8     
=========================================
  Hits          714      714             
- Misses        677      685      +8
Impacted Files Coverage Δ
Sources/XMLCoder/Encoder/XMLEncoder.swift 47.57% <0%> (-0.64%) ⬇️
Sources/XMLCoder/Decoder/XMLDecoder.swift 38.88% <37.5%> (-0.81%) ⬇️
Sources/XMLCoder/Auxiliaries/XMLHeader.swift 90.9% <50%> (-4.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 231a0d6...9109f62. Read the comment docs.

@regexident
Copy link
Contributor Author

Despite what codecov claims this is purely a syntactic change.
Code (instruction!) coverage hasn't been changed one bit by this PR.

@MaxDesiatov MaxDesiatov merged commit 4cad2df into CoreOffice:master Dec 23, 2018
@regexident regexident deleted the fix/guards branch December 24, 2018 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants