Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved _XML…EncodingContainer into their own files, matching decoder #4

Merged
merged 6 commits into from Dec 14, 2018
Merged

Moved _XML…EncodingContainer into their own files, matching decoder #4

merged 6 commits into from Dec 14, 2018

Conversation

regexident
Copy link
Contributor

The XMLEncoder.swift is far too large as it is right now.

I thus moved _XMLUnkeyedEncodingContainer and _XMLKeyedEncodingContainer into their own respective files.

Note: The Decoder directory already does the same.

@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #4 into master will increase coverage by 4.1%.
The diff coverage is 43.78%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #4     +/-   ##
=========================================
+ Coverage   34.57%   38.68%   +4.1%     
=========================================
  Files          12       14      +2     
  Lines        1585     1440    -145     
=========================================
+ Hits          548      557      +9     
+ Misses       1037      883    -154
Impacted Files Coverage Δ
Sources/XMLCoder/XMLKey.swift 25% <ø> (ø) ⬆️
Sources/XMLCoder/ISO8601DateFormatter.swift 0% <ø> (ø) ⬆️
...rces/XMLCoder/Encoder/EncodingErrorExtension.swift 0% <ø> (ø) ⬆️
...XMLCoder/Encoder/XMLUnkeyedEncodingContainer.swift 23.25% <23.25%> (ø)
...s/XMLCoder/Encoder/XMLKeyedEncodingContainer.swift 50.4% <50.4%> (ø)
Sources/XMLCoder/Encoder/XMLEncoder.swift 43.43% <66.66%> (+13.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f07759...1735601. Read the comment docs.

@regexident
Copy link
Contributor Author

🤔 this didn't change any logic. Just moving stuff around and changing some stuff from fileprivate to internal.

@MaxDesiatov
Copy link
Collaborator

LGTM, again hoping that merge of #1 will make codecov checks pass and then this one's good to merge.

@MaxDesiatov MaxDesiatov merged commit 7e13f4b into CoreOffice:master Dec 14, 2018
@regexident regexident deleted the fix/container-separation branch December 14, 2018 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants