Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary do … catch blocks in unit tests & add tests for missing values #40

Merged
merged 3 commits into from Dec 23, 2018
Merged

Conversation

regexident
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 23, 2018

Codecov Report

Merging #40 into master will increase coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   51.32%   51.76%   +0.43%     
==========================================
  Files          29       29              
  Lines        1391     1391              
==========================================
+ Hits          714      720       +6     
+ Misses        677      671       -6
Impacted Files Coverage Δ
...s/XMLCoder/Decoder/XMLKeyedDecodingContainer.swift 42.85% <0%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 231a0d6...200b973. Read the comment docs.

Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, I didn't know that test functions can throw 👍

@MaxDesiatov MaxDesiatov merged commit fb07143 into CoreOffice:master Dec 23, 2018
@regexident regexident deleted the fix/unit-tests branch December 24, 2018 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants