Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code coverage of box types #42

Merged
merged 4 commits into from Dec 24, 2018
Merged

Improve code coverage of box types #42

merged 4 commits into from Dec 24, 2018

Conversation

regexident
Copy link
Contributor

@regexident regexident commented Dec 23, 2018

… and remove unused internal methods to reduce the maintenance burden.

@codecov
Copy link

codecov bot commented Dec 23, 2018

Codecov Report

Merging #42 into master will increase coverage by 2.79%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #42      +/-   ##
=========================================
+ Coverage   51.41%   54.2%   +2.79%     
=========================================
  Files          29      29              
  Lines        1412    1402      -10     
=========================================
+ Hits          726     760      +34     
+ Misses        686     642      -44
Impacted Files Coverage Δ
Sources/XMLCoder/Box/KeyedBox.swift 100% <100%> (+22.72%) ⬆️
Sources/XMLCoder/Box/UnkeyedBox.swift 100% <100%> (+42.85%) ⬆️
Sources/XMLCoder/Box/DateBox.swift 95.74% <0%> (+4.25%) ⬆️
Sources/XMLCoder/Box/FloatBox.swift 100% <0%> (+10%) ⬆️
Sources/XMLCoder/Box/DataBox.swift 100% <0%> (+10.52%) ⬆️
Sources/XMLCoder/Box/BoolBox.swift 100% <0%> (+13.33%) ⬆️
Sources/XMLCoder/Box/IntBox.swift 100% <0%> (+14.28%) ⬆️
Sources/XMLCoder/Box/URLBox.swift 100% <0%> (+14.28%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d22e01...267c7ed. Read the comment docs.

@regexident
Copy link
Contributor Author

Ready to merge.

Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a bit unclear whether a test case property box should be a variable instead of a constant.

Tests/XMLCoderTests/Box/KeyedBoxTests.swift Outdated Show resolved Hide resolved
@regexident regexident changed the title Improve code coverage Improve code coverage of box types Dec 23, 2018
@regexident regexident closed this Dec 23, 2018
@regexident regexident deleted the fix/code-coverage branch December 23, 2018 22:59
@regexident regexident restored the fix/code-coverage branch December 23, 2018 23:17
@regexident regexident reopened this Dec 23, 2018
@regexident
Copy link
Contributor Author

Ugh, turns out renaming a branch backing a PR is not best idea I ever had. 😅🙈

@hodovani hodovani merged commit 68f9c8f into CoreOffice:master Dec 24, 2018
@regexident regexident deleted the fix/code-coverage branch December 24, 2018 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants