Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary use of @available(…) for OutputFormatting.sortedKeys #53

Merged
merged 1 commit into from Jan 2, 2019
Merged

Remove unnecessary use of @available(…) for OutputFormatting.sortedKeys #53

merged 1 commit into from Jan 2, 2019

Conversation

regexident
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #53 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   56.24%   56.18%   -0.07%     
==========================================
  Files          30       30              
  Lines        1433     1431       -2     
==========================================
- Hits          806      804       -2     
  Misses        627      627
Impacted Files Coverage Δ
Sources/XMLCoder/Encoder/XMLEncoder.swift 47.57% <ø> (ø) ⬆️
Sources/XMLCoder/Auxiliaries/XMLElement.swift 94.3% <100%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4e7673...02bd3fc. Read the comment docs.

Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @regexident, sorry for the delay with reviews of other PRs. I was focused on a different project during the last few weeks and was also waiting until XMLCoder overall has better test coverage before reviewing and merging more disruptive PRs. All PRs that increase the test coverage are welcome and I assume can be reviewed and merged quite quickly.

@MaxDesiatov
Copy link
Collaborator

@regexident please don't consider the previous comment as discouraging against substantial improvements, it only means that those will need more time to review and discuss, and I will get to those in the next few weeks anyway.

@hodovani hodovani merged commit 32d632f into CoreOffice:master Jan 2, 2019
@regexident regexident deleted the fix/availability branch January 2, 2019 15:16
bwetherfield added a commit to bwetherfield/XMLCoder that referenced this pull request Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants