Change XMLElement’s internal representation to ordered array of children
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
=========================================
+ Coverage 74.66% 74.7% +0.04%
=========================================
Files 31 31
Lines 1551 1550 -1
=========================================
Hits 1158 1158
+ Misses 393 392 -1
Continue to review full report at Codecov.
|
|
Hi @regexident, i found that tests failed (https://travis-ci.org/MaxDesiatov/XMLCoder/builds/476326902#L3100) at testing ClassTest.swift file and that redirect us to https://github.com/MaxDesiatov/XMLCoder/blob/51e1d21f3ef7dc9bc192be745b648526c7104b01/Sources/XMLCoder/Auxiliaries/XMLElement.swift#L48 where box is unclassified. Could you please have a look and help us fix it before this could be merged? |
This was referenced Jan 12, 2019
…-element # Conflicts: # Sources/XMLCoder/Auxiliaries/XMLElement.swift # Sources/XMLCoder/Decoder/XMLKeyedDecodingContainer.swift # Sources/XMLCoder/Decoder/XMLUnkeyedDecodingContainer.swift # XMLCoder.xcodeproj/project.pbxproj
MaxDesiatov
approved these changes
Jan 13, 2019
hodovani
approved these changes
Jan 13, 2019
|
Thanks @MaxDesiatov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #36
This change is one of many changes necessary to allow/prepare for order-preservation.