Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Swift version for packaging, refine CI #60

Merged
merged 1 commit into from Jan 7, 2019
Merged

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Jan 7, 2019

This sets Swift version to 4.2 for both SwiftPM and CocoaPods. A swift test run has been added to .travis.yml, which makes CI builds longer, but looks like it's the only way to make sure SwiftPM builds work and generate code coverage at the same time.

Resolves #57

@MaxDesiatov MaxDesiatov self-assigned this Jan 7, 2019
@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   68.48%   68.48%           
=======================================
  Files          30       30           
  Lines        1431     1431           
=======================================
  Hits          980      980           
  Misses        451      451

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb4f1c...1e888d3. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit e04d921 into master Jan 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the swift-version branch January 7, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants