New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for keyed and unkeyed int types #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @hodovani! great stuff in general, but I think UnkeyedIntTests
has a lot of duplicated code that could be made generic similar to what we have in KeyedIntTests
in this same PR
""" | ||
|
||
class UnkeyedIntTests: XCTestCase { | ||
func testInt8() throws { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we create a new testIntArray
generic function here and call that function with a metatype argument similar to what is available in KeyedIntTests
?
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 68.68% 70.76% +2.08%
==========================================
Files 30 30
Lines 1440 1440
==========================================
+ Hits 989 1019 +30
+ Misses 451 421 -30
Continue to review full report at Codecov.
|
No description provided.