Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for keyed and unkeyed int types #62

Merged
merged 4 commits into from Jan 8, 2019
Merged

Conversation

hodovani
Copy link
Contributor

@hodovani hodovani commented Jan 8, 2019

No description provided.

@hodovani hodovani self-assigned this Jan 8, 2019
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @hodovani! great stuff in general, but I think UnkeyedIntTests has a lot of duplicated code that could be made generic similar to what we have in KeyedIntTests in this same PR

"""

class UnkeyedIntTests: XCTestCase {
func testInt8() throws {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we create a new testIntArray generic function here and call that function with a metatype argument similar to what is available in KeyedIntTests?

@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #62 into master will increase coverage by 2.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   68.68%   70.76%   +2.08%     
==========================================
  Files          30       30              
  Lines        1440     1440              
==========================================
+ Hits          989     1019      +30     
+ Misses        451      421      -30
Impacted Files Coverage Δ
Sources/XMLCoder/Auxiliaries/XMLElement.swift 95.12% <0%> (+0.81%) ⬆️
...s/XMLCoder/Decoder/XMLKeyedDecodingContainer.swift 85.1% <0%> (+6.38%) ⬆️
...XMLCoder/Decoder/XMLUnkeyedDecodingContainer.swift 24.42% <0%> (+15.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48d2c2c...b728554. Read the comment docs.

@hodovani hodovani merged commit 67934d9 into master Jan 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the unkeyed-int-tests branch January 8, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants