Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for array and dictionary properties #7

Merged
merged 2 commits into from Dec 16, 2018
Merged

Added unit tests for array and dictionary properties #7

merged 2 commits into from Dec 16, 2018

Conversation

regexident
Copy link
Contributor

@regexident regexident commented Nov 21, 2018

Array:

  • empty array
  • single element array
  • multi element array

Dictionary:

  • empty dictionary
  • single element dictionary
  • multi element dictionary

(A checkmark means the test runs successfully with the current implementation)

@codecov
Copy link

codecov bot commented Dec 16, 2018

Codecov Report

Merging #7 into master will increase coverage by 0.68%.
The diff coverage is 49.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   38.68%   39.36%   +0.68%     
==========================================
  Files          14       14              
  Lines        1440     1443       +3     
==========================================
+ Hits          557      568      +11     
+ Misses        883      875       -8
Impacted Files Coverage Δ
Sources/XMLCoder/Encoder/XMLEncoder.swift 43.43% <0%> (ø) ⬆️
Sources/XMLCoder/Decoder/XMLDecoder.swift 34.79% <33.33%> (+1.86%) ⬆️
...s/XMLCoder/Decoder/XMLKeyedDecodingContainer.swift 27.93% <44.44%> (+1.7%) ⬆️
Sources/XMLCoder/Encoder/XMLEncodingStorage.swift 88.88% <75%> (-11.12%) ⬇️
Sources/XMLCoder/Decoder/XMLDecodingStorage.swift 81.81% <80%> (ø) ⬆️
Sources/XMLCoder/XMLStackParser.swift 93.8% <0%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e13f4b...cf92e68. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit 20163e6 into CoreOffice:master Dec 16, 2018
@regexident regexident deleted the collection-tests branch December 16, 2018 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants