Fix compatibility with Swift 5.0 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=========================================
- Coverage 74.42% 74.4% -0.02%
=========================================
Files 37 37
Lines 1736 1735 -1
=========================================
- Hits 1292 1291 -1
Misses 444 444
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=========================================
- Coverage 74.42% 74.4% -0.02%
=========================================
Files 37 37
Lines 1736 1735 -1
=========================================
- Hits 1292 1291 -1
Misses 444 444
Continue to review full report at Codecov.
|
hodovani
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When XMLCoder is compiled in Swift 5.0 mode it causes infinite loops in some tests, apparently due to change in
try?behaviour introduced in SE-0230. In genericunboxhandling of theStringcase withtry? unbox(box)is always inferred as a call tounbox<String?>instead of a call tounbox<String>, as it was in Swift 4.2 mode. This is now fixed with rearranged type hints in this call. Also applied Swift 5.0 migrator suggestion to changeindextofirstIndex.