Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ordered encoding #82

Merged
merged 4 commits into from Mar 1, 2019
Merged

Ordered encoding #82

merged 4 commits into from Mar 1, 2019

Conversation

MaxDesiatov
Copy link
Collaborator

Resolves #17

@MaxDesiatov MaxDesiatov self-assigned this Feb 27, 2019
@MaxDesiatov
Merge branch 'master' of github.com:MaxDesiatov/XMLCoder into ordered…
d23c718 
…-encoding

# Conflicts:
#	Sources/XMLCoder/Auxiliaries/XMLCoderElement.swift
@MaxDesiatov MaxDesiatov changed the title First attempt at ordered encoding Ordered encoding Feb 27, 2019
@MaxDesiatov MaxDesiatov marked this pull request as ready for review March 1, 2019 10:21
@MaxDesiatov MaxDesiatov assigned hodovani and unassigned MaxDesiatov Mar 1, 2019
@codecov
Copy link

codecov bot commented Mar 1, 2019 •
edited

Codecov Report

Merging #82 into master will increase coverage by 0.22%.
The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   74.74%   74.97%   +0.22%     
==========================================
  Files          37       37              
  Lines        1758     1774      +16     
==========================================
+ Hits         1314     1330      +16     
  Misses        444      444
Impacted Files Coverage Δ
Sources/XMLCoder/Auxiliaries/XMLCoderElement.swift 95.42% <100%> (+0.07%) ⬆️
Sources/XMLCoder/Encoder/XMLEncoder.swift 79.2% <100%> (ø) ⬆️
Sources/XMLCoder/Auxiliaries/Box/KeyedBox.swift 100% <100%> (ø) ⬆️
Sources/XMLCoder/Encoder/DynamicNodeEncoding.swift 50% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbb4ba...05db212. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit f8616cf into master Mar 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the ordered-encoding branch March 1, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@hodovani hodovani hodovani approved these changes

Assignees

@hodovani hodovani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MaxDesiatov @houndci-bot @hodovani