Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DynamicNodeDecoding protocol #85

Merged
merged 11 commits into from Mar 25, 2019
Merged

Add DynamicNodeDecoding protocol #85

merged 11 commits into from Mar 25, 2019

Conversation

MaxDesiatov
Copy link
Collaborator

This adds new DynamicNodeDecoding protocol similar to DynamicNodeEncoding introduced in #70

@MaxDesiatov MaxDesiatov self-assigned this Mar 17, 2019
@codecov
Copy link

codecov bot commented Mar 17, 2019 •
edited

Codecov Report

Merging #85 into master will decrease coverage by <.01%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   76.94%   76.93%   -0.01%     
==========================================
  Files          37       37              
  Lines        1804     1812       +8     
==========================================
+ Hits         1388     1394       +6     
- Misses        416      418       +2
Impacted Files Coverage Δ
Sources/XMLCoder/Encoder/DynamicNodeEncoding.swift 50% <ø> (ø) ⬆️
Sources/XMLCoder/Encoder/XMLEncoder.swift 79.2% <100%> (ø) ⬆️
Sources/XMLCoder/Decoder/XMLDecoder.swift 80.55% <100%> (+0.97%) ⬆️
...rImplementation+SingleValueEncodingContainer.swift 94.64% <57.14%> (-5.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8deb55...49aca76. Read the comment docs.

@MaxDesiatov MaxDesiatov mentioned this pull request Mar 17, 2019
Merged
@MaxDesiatov MaxDesiatov marked this pull request as ready for review March 24, 2019 18:20
@MaxDesiatov MaxDesiatov assigned hodovani and unassigned MaxDesiatov Mar 24, 2019
@MaxDesiatov MaxDesiatov merged commit 40222d8 into master Mar 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the dynamic-node-decoding branch March 25, 2019 10:08
@MaxDesiatov MaxDesiatov mentioned this pull request Mar 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodovani hodovani hodovani approved these changes

Assignees

@hodovani hodovani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MaxDesiatov @hodovani