Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate lint stage to .travis.yml #87

Merged
merged 17 commits into from Apr 2, 2019
Merged

Add separate lint stage to .travis.yml #87

merged 17 commits into from Apr 2, 2019

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Mar 30, 2019

This prevents linting stage from running multiple times in all parallel jobs. We're mostly going to develop with the latest version of Xcode, so we only care about linter and formatter warnings with that version. Thus, the linter stage runs first with the latest version, while actual tests run in parallel jobs of the next "test" stage.

@codecov
Copy link

codecov bot commented Mar 30, 2019

Codecov Report

Merging #87 into master will increase coverage by 1.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #87     +/-   ##
=========================================
+ Coverage   76.93%   78.04%   +1.1%     
=========================================
  Files          37       37             
  Lines        1812     2022    +210     
=========================================
+ Hits         1394     1578    +184     
- Misses        418      444     +26
Impacted Files Coverage Δ
Sources/XMLCoder/Auxiliaries/XMLStackParser.swift 93.54% <100%> (+0.36%) ⬆️
...rces/XMLCoder/Decoder/DecodingErrorExtension.swift 65.21% <0%> (-34.79%) ⬇️
Sources/XMLCoder/Auxiliaries/XMLCoderElement.swift 97.67% <0%> (-0.04%) ⬇️
...s/XMLCoder/Decoder/XMLKeyedDecodingContainer.swift 83.98% <0%> (+0.26%) ⬆️
Sources/XMLCoder/Encoder/XMLEncoder.swift 80% <0%> (+0.79%) ⬆️
...s/XMLCoder/Encoder/XMLKeyedEncodingContainer.swift 77.39% <0%> (+4.45%) ⬆️
...XMLCoder/Encoder/XMLUnkeyedEncodingContainer.swift 29.41% <0%> (+6%) ⬆️
...XMLCoder/Decoder/XMLUnkeyedDecodingContainer.swift 37.57% <0%> (+22.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 705bd7d...726be42. Read the comment docs.

@MaxDesiatov MaxDesiatov marked this pull request as ready for review March 30, 2019 15:14
@MaxDesiatov MaxDesiatov merged commit 847d754 into master Apr 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the lint-stage branch April 2, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants