Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR depends on and includes #88.
Recent addition of value intrinsic allows XMLCoder to handle last few known edge cases, but still a lot of times the shape of an XML isn't guaranteed to be always the same. E.g. some of the attributes might be present or absent, but an element without attributes is never decoded as a
KeyedBox
even with a value intrinsic. And vice versa, aKeyedBox
with attributes can't be decoded with a primitive type that maps to the element value.This was previously reported by @Inukinator as an issue in InukVT/Read#2.
Consider this sample XML:
As of 847d754 this can't be decoded as
And this xml:
can't be decoded with
This is fixed now with added optional down casts that peek into the box structure and map it correctly in these remaining edge cases.