Fix decoding empty element as optional #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
changed the title
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 76.97% 77.05% +0.07%
==========================================
Files 38 38
Lines 2111 2114 +3
==========================================
+ Hits 1625 1629 +4
+ Misses 486 485 -1
Continue to review full report at Codecov.
|
houndci-bot
reviewed
Apr 29, 2019
hodovani
approved these changes
May 1, 2019
arjungupta0107
pushed a commit
to salido/XMLCoder
that referenced
this pull request
Jun 26, 2020
Fix an issue uncovered by CoreOffice/CoreXLSX#59. Also include slightly unrelated cleanups. Resolve CoreOffice#94 * Fix empty element decoded as optional * Add failing test case to SpacePreserveTest * Disable `nesting` SwiftLint rule * Fix handling of nested empty string values * Add trimValueWhitespaces property on XMLDecoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue uncovered by CoreOffice/CoreXLSX#59. Also include slightly unrelated cleanups.
Resolves #94