Rename flatten to transformToBoxTree, rename tests #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 77.04% 77.04%
=======================================
Files 38 38
Lines 2113 2113
=======================================
Hits 1628 1628
Misses 485 485
Continue to review full report at Codecov.
|
hodovani
approved these changes
May 2, 2019
arjungupta0107
pushed a commit
to salido/XMLCoder
that referenced
this pull request
Jun 26, 2020
After a close look `flatten` doesn't actually flatten anything, it only transforms a tree of `XMLCoderElement`s to a tree of `Box`es. * Rename flatten to transformToBoxTree, rename tests * Rename FlattenTests file and header * Update KeyedStorage.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a close look
flattendoesn't actually flatten anything, it only transforms a tree ofXMLCoderElements to a tree ofBoxes.