Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaInfo 23.07 is still not DPI awareness #750

Closed
NewUserHa opened this issue Aug 8, 2023 · 7 comments · Fixed by #835
Closed

MediaInfo 23.07 is still not DPI awareness #750

NewUserHa opened this issue Aug 8, 2023 · 7 comments · Fixed by #835
Assignees

Comments

@NewUserHa
Copy link

NewUserHa commented Aug 8, 2023

MediaInfo 23.07 is still not DPI awareness, this issue is since from version 18.05.
image
very blurry
vs
manually changed dpi by application:
image

win10

@userzzzq
Copy link

maybe the developer still use 1080p monitor

@JeromeMartinez
Copy link
Member

maybe the developer still use 1080p monitor

True. also our sponsors, so not their priority, but we understand that this is annoying, we need at some point to find how to fix that.
Patch welcome if you know.

@cjee21
Copy link
Contributor

cjee21 commented May 17, 2024

If manually setting the DPI works as mentioned in the first post, adding the following to the manifest should do it. No other changes needed if everything is displayed properly after enabling high DPI.

<asmv3:application>
    <asmv3:windowsSettings>
        <dpiAware>true</dpiAware>
        <dpiAwareness>PerMonitorV2</dpiAwareness>
    </asmv3:windowsSettings>
</asmv3:application>

For GDI-based applications:

<asmv3:application>
    <asmv3:windowsSettings>
        <gdiScaling>true</gdiScaling>
    </asmv3:windowsSettings>
</asmv3:application>

Edit: browsing this repo it seems MediaInfo is using VCL, in that case maybe this will help: https://blogs.embarcadero.com/windows-10-and-modern-high-dpi-display-support-in-delphi-and-c-builder/

@cjee21
Copy link
Contributor

cjee21 commented May 18, 2024

I tried implementing high DPI support to MediaInfo. Here's how it looks compared to existing version at 150% scale.
Screenshot 2024-05-18 212844

Overall everything seems to look fine. There's a bit of alignment difference in the menu bar and the sponsor(AD) button became blue on hover for some reason. I do not know how to further improve this.

Screenshot 2024-05-18 221828
Here's how it compares in Process Explorer showing the DPI-awareness.
I noticed the official MediaInfo is not built with DEP and ASLR enabled?

@cjee21
Copy link
Contributor

cjee21 commented May 18, 2024

I fixed the sponsor(AD) button became blue on hover issue. Does this look okay? (screenshots taken with DPI set to 150% scale)
Screenshot 2024-05-19 001821
Screenshot 2024-05-19 001848
Screenshot 2024-05-19 001859

Should I create a pull request?

@JeromeMartinez
Copy link
Member

Should I create a pull request?

It would be greatly appreciated!

I noticed the official MediaInfo is not built with DEP and ASLR enabled?

We checked a bit that some time ago but didn't finish to check as we don't know much about it so we weren't sure about what we do, if you have a patch ready we take it :).

@cjee21
Copy link
Contributor

cjee21 commented May 19, 2024

We checked a bit that some time ago but didn't finish to check as we don't know much about it so we weren't sure about what we do, if you have a patch ready we take it :).

For enabling DEP and ASLR, just need to enable these two options in Project Options:
Screenshot 2024-05-19 153510

It appears to be auto-enabled here so I don't know whether these settings are saved in the project file or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants