Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure the drain-skip labels on the side of network-operator for the driver upgrade #500

Open
almaslennikov opened this issue May 3, 2023 · 2 comments
Labels
enhancement New feature or request priority-medium

Comments

@almaslennikov
Copy link
Collaborator

Currently the label for pods that allows them to be skipped during drain, is configured in the common driver upgrade library.
This approach is unclear since it's not part of the explicit public API.
We can configure our own such label by including one more expression into the podSelector in the drain spec. This logic for handling drain skip should also be removed from the https://github.com/NVIDIA/k8s-operator-libs

@nadavrub
Copy link

Q: "We can configure our own such label" - does this mean there would B redundancy w/ the CommonUpgrade lib, or should there B a corresponding fix to remove the logic from that lib?
A: There will be redundancy. I think the best course of action would be to apply the change to net-op, notify the gpu op team and drop when/if they apply the same change to their code

@adrianchiris
Copy link
Collaborator

support was merged in k8s-operator-libs in: NVIDIA/k8s-operator-libs@f698677

update to network operator will be done as part of PR #685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-medium
Projects
None yet
Development

No branches or pull requests

3 participants