Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove override of node affinity for sriov-network-operator chart #531

Open
adrianchiris opened this issue May 23, 2023 · 1 comment
Open
Labels
priority-low A low priority issue refactoring Code refactoring

Comments

@adrianchiris
Copy link
Collaborator

When [1] is merged we can just take that chart and remove the override we have in helm values [2]

while at it, we can also remove the toleration and possibly any other value that is identical to the default.

[1] k8snetworkplumbingwg/sriov-network-operator#444
[2]

@adrianchiris adrianchiris added refactoring Code refactoring priority-low A low priority issue labels May 23, 2023
@adrianchiris
Copy link
Collaborator Author

update: k8snetworkplumbingwg/sriov-network-operator#444 was merged.

e0ne added a commit that referenced this issue Apr 24, 2024
…alues (#902)

Based on #531

The deleted fields copy the default values of the sriov-network-operator
chart. Dropping them doesn't affect the deployment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-low A low priority issue refactoring Code refactoring
Projects
None yet
Development

No branches or pull requests

1 participant