Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors are not reported in CR status #533

Closed
adrianchiris opened this issue May 23, 2023 · 0 comments · Fixed by #895
Closed

Errors are not reported in CR status #533

adrianchiris opened this issue May 23, 2023 · 0 comments · Fixed by #895
Labels
bug Something isn't working priority-medium

Comments

@adrianchiris
Copy link
Collaborator

adrianchiris commented May 23, 2023 •
edited

What happened:

if an error occurs when syncing state, we should update global status with the first error encountered (in controller)

while this is true for some controllers, it is not for others
in addition the different states in most cases that an error occured return SyncStateNotReady instead of SyncStateError
this should be reviewed and fixed for all states.
rollandf added a commit to rollandf/network-operator that referenced this issue Apr 17, 2024
@rollandf
feat: Support errors on NCP status
10cb4ee 
Fixes Mellanox#533

Signed-off-by: Fred Rolland <frolland@nvidia.com>
@rollandf rollandf mentioned this issue Apr 17, 2024
Merged
rollandf added a commit to rollandf/network-operator that referenced this issue May 15, 2024
@rollandf
feat: Support errors on NCP status
031c7ec 
Fixes Mellanox#533

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/network-operator that referenced this issue May 23, 2024
@rollandf
feat: Support errors on NCP status
0a7d102 
Fixes Mellanox#533

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/network-operator that referenced this issue May 27, 2024
@rollandf
feat: Support errors on NCP status
f8bc1ab 
Fixes Mellanox#533

Signed-off-by: Fred Rolland <frolland@nvidia.com>
adrianchiris added a commit that referenced this issue May 28, 2024
@adrianchiris
feat: Support errors on NCP status (#895)
09cdb17 
Fixes #533

Example status:
```
status:
  appliedStates:
  - name: state-multus-cni
    state: ignore
  - name: state-container-networking-plugins
    state: ignore
  - name: state-ipoib-cni
    state: ignore
  - name: state-whereabouts-cni
    state: ignore
  - error: 'failed to create k8s objects from manifest: failed to render objects:
      ForcePrecompiled is enabled and precompiled image was not found'
    name: state-OFED
    state: notReady
  - name: state-SRIOV-device-plugin
    state: ignore

```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority-medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support errors on NCP status rollandf/network-operator
1 participant
@adrianchiris