Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Successful check hides failed check of same name #5083

Open
Nuru opened this issue Apr 6, 2023 · 0 comments
Open

Bug: Successful check hides failed check of same name #5083

Nuru opened this issue Apr 6, 2023 · 0 comments

Comments

@Nuru
Copy link

Nuru commented Apr 6, 2023

Expected Behavior

If a PR has 2 check runs with the same name, and one fails and one succeeds, after they both finish

  • "#check-failure=1" should be true
  • "#check-success=1" should be true

Actual Behavior

Tested with the Mergify config editor against a more complex PR that has been closed and merged, effectively the results are

  • "#check-failure=1" is false
  • "#check-failure=0" is true
  • "#check-success=1" is true

Steps to Reproduce the Problem

  1. Create two workflows (different files) with the same job name. One workflow always succeeds, one workflow always fails.
  2. Use a Mergify configuration with condition checking for zero pending, 1 failure, 1 success.
  3. See that the condition is never satisfied, because at the end of the runs, "#check-failure=1" is false.

Specifications

More details in this discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant