Remove providerConfig from NetworkController #4254
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
remove-provider-config
branch
from
d1359dd
to
9b3cc0a
Compare
Historically, the `providerConfig` property in NetworkController has been used to track the currently selected network as well as provide access to information about that network. The selected network is now tracked via `selectedNetworkClientId`, and information about that network can be retrieved by looking at the `networkConfigurations` property or the `configuration` property on the NetworkClient interface. This means that we no longer need `providerConfig` and we can remove this redundant state.
mcmire
force-pushed
the
remove-provider-config
branch
from
9b3cc0a
to
730b264
Compare
legobeat
reviewed
May 8, 2024
| ); | ||
| const { chainId } = selectedNetworkClient.configuration; | ||
|
|
||
| if (this.config.chainId !== chainId) { |
There was a problem hiding this comment.
Is there a test-case for when chainId differs? If not, that could explain the reduced coverage %?
There was a problem hiding this comment.
I looked into this and I don't think it's due to additional logic. Somehow I have made something that was inadvertently tested not tested anymore. Regrettably I have added an istanbul directive to ignore the logic in question: be7f9c2
|
I'm going to break this up into multiple PRs as this one is rather large and difficult to review. Placing in draft until that's complete.
After that we can rebase this PR and reopen it for review. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Historically, the
providerConfigproperty in NetworkController has been used to track the currently selected network as well as provide access to information about that network. The selected network is now tracked viaselectedNetworkClientId, and information about that network can be retrieved by looking at thenetworkConfigurationsproperty or theconfigurationproperty on the NetworkClient interface. This means that we no longer needproviderConfigand we can remove this redundant state.References
Fixes #4185.
Changelog
@metamask/assets-controllersChanged
NetworkController:getNetworkClientById(#4254)@metamask/ens-controllerChanged
NetworkController:getNetworkClientById(#4254)onNetworkDidChangeso that it may take the full NetworkController state instead of simply an object with aproviderConfigproperty (#4254)@metamask/network-controllerRemoved
providerConfigproperty from state along withProviderConfigtype andNetworkController:getProviderConfigmessenger action (#4254)state.selectedNetworkClientId, pass this to theNetworkController:getNetworkClientIdmessenger action, and then access theconfigurationproperty on the network client.networksMetadatastate property so that the keys in the object will only ever contain network client IDs and not RPC URLs (#4254)Checklist