Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token Rates request rate higher than expected #4186

Open
blurpesec opened this issue Apr 18, 2024 · 3 comments
Open

Token Rates request rate higher than expected #4186

blurpesec opened this issue Apr 18, 2024 · 3 comments
Labels
bug Something isn't working team-wallet-framework

Comments

@blurpesec
Copy link
Contributor

Background

Starting in January, we migrated token pricing provider from Coingecko to an internal PriceAPI. At the time we were quoted a number of requests per day to expect once full rollout occurred. Currently we're doing ~10x that rate.

There has previously been some discussion around one or more of the apps possibly defaulting to an "open" state on browser load, regardless of if the app is "open" - which starts polling for token rates until the app is actually opened, then closed again.

Impact

The current impact of this is ~10x expected traffic to our internal Price API service which is a much higher-than-expected cost.

@blurpesec blurpesec added the bug Something isn't working label Apr 19, 2024
@desi
Copy link

desi commented May 1, 2024

Desi to discuss this with Gauthier about whether this should be investigated by the client teams. Need to have a lightweight step to gauge our volume.

@bergeron
Copy link
Contributor

bergeron commented May 3, 2024

Expect an improvement in extension 11.16.0. It used to poll in the background on browser open, even if you never opened metamask:

MetaMask/metamask-extension#24021

@desi
Copy link

desi commented May 9, 2024

Will check back in with Michael on this after 11.16 is out for a bit to see if we are still seeing the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working team-wallet-framework
Projects
None yet
Development

No branches or pull requests

3 participants