Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename approved permission request data property #4218

Open
rekmarks opened this issue Apr 26, 2024 · 0 comments
Open

Rename approved permission request data property #4218

rekmarks opened this issue Apr 26, 2024 · 0 comments
Labels
enhancement New feature or request PermissionController Related to the PermissionController.

Comments

@rekmarks
Copy link
Member

The data property of the approved permission request metadata (i.e. the second value in the returned tuple here) is actually only used for permission request side effects, and should be renamed sideEffectData or something similarly specific.
@rekmarks rekmarks added enhancement New feature or request PermissionController Related to the PermissionController. labels Apr 26, 2024
@rekmarks rekmarks self-assigned this Apr 26, 2024
@rekmarks rekmarks changed the title PermissionController: Rename approved permission request data property Rename approved permission request data property May 1, 2024
@rekmarks rekmarks removed their assignment May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request PermissionController Related to the PermissionController.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rekmarks