Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit test coverage #208

Open
9 tasks
Gudahtt opened this issue Sep 16, 2021 · 0 comments
Open
9 tasks

Improve unit test coverage #208

Gudahtt opened this issue Sep 16, 2021 · 0 comments

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Sep 16, 2021

The unit test coverage was recently dramatically expanded, but there are still a few gaps.

  • We are missing typedSignatureHash tests for array inputs.
  • We aren't testing negative number inputs passed in as strings.
  • We aren't testing numbers encoded as strings of odd v.s. even length.
  • personal_sign isn't thoroughly tested in general (e.g. we only test '0x'-prefixed hex string inputs).
  • Encryption isn't thoroughly tested (e.g. Add working decryption failure test #75 )
  • We don't have tests for naming collisions between custom types and Solidity types.
  • We don't have any tests for arrays of a set size. We only have dynamic length array tests.
  • We don't have tests for arrays of arrays.
  • We don't have tests for custom types that behave like arrays.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant