{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":42009758,"defaultBranch":"develop","name":"metamask-extension","ownerLogin":"MetaMask","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-09-06T16:34:48.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/11744586?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716329523.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"15c4cdc94458c79b7282a79cb8c7e780114fb3b4","ref":"refs/heads/fix/replace-metafi-metaswap-subdomains","pushedAt":"2024-05-21T22:12:03.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"cryptodev-2s","name":null,"path":"/cryptodev-2s","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/109512101?s=80&v=4"},"commit":{"message":"Migrate API usage from *.metafi and *.metaswap subdomains to *.api.cx.metamask.io","shortMessageHtmlLink":"Migrate API usage from *.metafi and *.metaswap subdomains to *.api.cx…"}},{"before":"bfdc3de71aec39ca6f87ed87523f55bff20b11bb","after":"4acd228894314c42919b63f6ce6760751a7e67c8","ref":"refs/heads/all-the-mv3-e2e-fixes","pushedAt":"2024-05-21T21:57:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"danjm","name":"Dan J Miller","path":"/danjm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7499938?s=80&v=4"},"commit":{"message":"Update circlie config","shortMessageHtmlLink":"Update circlie config"}},{"before":"3f0961b0e52b4bbc0bc96d3ef99f615adb8d4214","after":"e8ad3b9d5737e65bea877501907f2b1ed91b4d5d","ref":"refs/heads/feat/implement-personal-sign-alerts","pushedAt":"2024-05-21T21:45:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vinistevam","name":"Vinicius Stevam","path":"/vinistevam","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45455812?s=80&v=4"},"commit":{"message":"applied design qa feedback","shortMessageHtmlLink":"applied design qa feedback"}},{"before":"4f13f8e93a9e855039d9efd3a2651a2ff5e762af","after":"5cb56b2124ae0dfe03ed6efb2918e31406f7a671","ref":"refs/heads/delete-metametrics-data-controller","pushedAt":"2024-05-21T21:27:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"NiranjanaBinoy","name":"Niranjana Binoy","path":"/NiranjanaBinoy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43930900?s=80&v=4"},"commit":{"message":"updating the controller pattern, renaming the env variable, updating some state files to fix circle ci failure'","shortMessageHtmlLink":"updating the controller pattern, renaming the env variable, updating …"}},{"before":"90dc1eff07eadfee9e2f436b12fd85c450ba3ca9","after":"3f0961b0e52b4bbc0bc96d3ef99f615adb8d4214","ref":"refs/heads/feat/implement-personal-sign-alerts","pushedAt":"2024-05-21T21:25:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"vinistevam","name":"Vinicius Stevam","path":"/vinistevam","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/45455812?s=80&v=4"},"commit":{"message":"applied design qa feedback","shortMessageHtmlLink":"applied design qa feedback"}},{"before":"9360e51ade10348c3607cea4bc556cf09f8f1ce9","after":"5db1dc77a7c29784c5ee06b231a5005be591665e","ref":"refs/heads/l10n_crowdin_action","pushedAt":"2024-05-21T21:21:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"New Crowdin translations by Github Action","shortMessageHtmlLink":"New Crowdin translations by Github Action"}},{"before":"4d8da347d6342c1c82f148f1386c3e374b7c9114","after":null,"ref":"refs/heads/fb/snaps-bump-v47","pushedAt":"2024-05-21T21:20:35.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"FrederikBolding","name":"Frederik Bolding","path":"/FrederikBolding","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1561200?s=80&v=4"}},{"before":"4233f9ed062e2d84250c45f17e8bb0dd2dafaaab","after":"ad3b3668f95071d30e2a1d1512e419b192844809","ref":"refs/heads/develop","pushedAt":"2024-05-21T21:20:34.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"FrederikBolding","name":"Frederik Bolding","path":"/FrederikBolding","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1561200?s=80&v=4"},"commit":{"message":"chore: bump Snaps packages (#24550)\n\n## **Description**\r\nBump snaps packages to latest and handle breaking changes.\r\n\r\nSummary of changes in the snaps deps:\r\n- **BREAKING:** Use hooks in `wallet_invokeSnap` instead of remapping\r\nthe request to `wallet_snap`\r\n- Add support for BIP-32-Ed25519 / CIP-3 key derivation","shortMessageHtmlLink":"chore: bump Snaps packages (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2299678631\" data-permission-text=\"Title is private\" data-url=\"https://github.com/MetaMask/metamask-extension/issues/24550\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/MetaMask/metamask-extension/pull/24550/hovercard\" href=\"https://github.com/MetaMask/metamask-extension/pull/24550\">#24550</a>)"}},{"before":null,"after":"7803a917a6706a03b7b1115a41b947e40793b063","ref":"refs/heads/allow-undefined-enableMV3TimestampSave","pushedAt":"2024-05-21T21:04:53.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"danjm","name":"Dan J Miller","path":"/danjm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7499938?s=80&v=4"},"commit":{"message":"Only prevent the service worker timestamp save if initState.PreferencesController?.enableMV3TimestampSave is false","shortMessageHtmlLink":"Only prevent the service worker timestamp save if initState.Preferenc…"}},{"before":null,"after":"bfdc3de71aec39ca6f87ed87523f55bff20b11bb","ref":"refs/heads/all-the-mv3-e2e-fixes","pushedAt":"2024-05-21T21:01:14.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"danjm","name":"Dan J Miller","path":"/danjm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7499938?s=80&v=4"},"commit":{"message":"Add createDupeReqFilterMiddleware() to the middleware pipeline before any controller specific middleware","shortMessageHtmlLink":"Add createDupeReqFilterMiddleware() to the middleware pipeline before…"}},{"before":"3916349537d51f828b45daf2fc196d04e102e743","after":"df5964e163e975f8c407104955c2dac45956abe0","ref":"refs/heads/zb/switch-as-perm-poc-chainid","pushedAt":"2024-05-21T20:55:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"adonesky1","name":"Alex Donesky","path":"/adonesky1","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34557516?s=80&v=4"},"commit":{"message":"further dedupe","shortMessageHtmlLink":"further dedupe"}},{"before":null,"after":"2af42c81af222ec982594dbc5bff852e6b7814f0","ref":"refs/heads/simplify-chromedriver-arguments","pushedAt":"2024-05-21T20:45:35.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"danjm","name":"Dan J Miller","path":"/danjm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7499938?s=80&v=4"},"commit":{"message":"Remove user-data-dir usage in tests on mv3 builds","shortMessageHtmlLink":"Remove user-data-dir usage in tests on mv3 builds"}},{"before":"4c4b6a0fba41f862bd04ea70e9674e1fb0724770","after":"57d9a5fd07f80349646646e8aceccf9e1cf5e572","ref":"refs/heads/mb843-swaps-blocked-tokens","pushedAt":"2024-05-21T20:38:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"micaelae","name":null,"path":"/micaelae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/100321200?s=80&v=4"},"commit":{"message":"chore: disable swap+send when from token is in blocked list","shortMessageHtmlLink":"chore: disable swap+send when from token is in blocked list"}},{"before":null,"after":"d17b403df50481cbb49407a3ab24991438e5f198","ref":"refs/heads/fix-app-installed.spec.js","pushedAt":"2024-05-21T20:37:15.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"danjm","name":"Dan J Miller","path":"/danjm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7499938?s=80&v=4"},"commit":{"message":"Reduce appInstalledEvent timeout delay","shortMessageHtmlLink":"Reduce appInstalledEvent timeout delay"}},{"before":"8c33ea672f9400a659110d3c7336644eca20c481","after":"3916349537d51f828b45daf2fc196d04e102e743","ref":"refs/heads/zb/switch-as-perm-poc-chainid","pushedAt":"2024-05-21T20:36:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"adonesky1","name":"Alex Donesky","path":"/adonesky1","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34557516?s=80&v=4"},"commit":{"message":"add one missing piece of validation back to switch-ethereum-chain","shortMessageHtmlLink":"add one missing piece of validation back to switch-ethereum-chain"}},{"before":"9f416d68ba23367a9dc776248a4a635545fcfa9e","after":"8c33ea672f9400a659110d3c7336644eca20c481","ref":"refs/heads/zb/switch-as-perm-poc-chainid","pushedAt":"2024-05-21T20:34:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"adonesky1","name":"Alex Donesky","path":"/adonesky1","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34557516?s=80&v=4"},"commit":{"message":"cleanup test names","shortMessageHtmlLink":"cleanup test names"}},{"before":"af9bbff498942fa979b2eb5f3e6a17e5eee1ad95","after":"9f416d68ba23367a9dc776248a4a635545fcfa9e","ref":"refs/heads/zb/switch-as-perm-poc-chainid","pushedAt":"2024-05-21T20:25:23.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"adonesky1","name":"Alex Donesky","path":"/adonesky1","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34557516?s=80&v=4"},"commit":{"message":"setupMocks -> makeMocks","shortMessageHtmlLink":"setupMocks -&gt; makeMocks"}},{"before":null,"after":"f239c7b2912d7f758439a323cabe43c444be6265","ref":"refs/heads/fix-import-tokens-spec","pushedAt":"2024-05-21T20:22:23.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"danjm","name":"Dan J Miller","path":"/danjm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7499938?s=80&v=4"},"commit":{"message":"Improve flakiness of await driver.findElements in 'importing multiple tokens from search' test","shortMessageHtmlLink":"Improve flakiness of await driver.findElements in 'importing multiple…"}},{"before":"9d07ed684b9484b5f42a3baea873a39aa413be7e","after":"af9bbff498942fa979b2eb5f3e6a17e5eee1ad95","ref":"refs/heads/zb/switch-as-perm-poc-chainid","pushedAt":"2024-05-21T20:17:44.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"adonesky1","name":"Alex Donesky","path":"/adonesky1","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34557516?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into zb/switch-as-perm-poc-chainid","shortMessageHtmlLink":"Merge branch 'develop' into zb/switch-as-perm-poc-chainid"}},{"before":"c1798c9088c9891637d2678dbb9c03baccf40551","after":"9d07ed684b9484b5f42a3baea873a39aa413be7e","ref":"refs/heads/zb/switch-as-perm-poc-chainid","pushedAt":"2024-05-21T20:16:26.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"adonesky1","name":"Alex Donesky","path":"/adonesky1","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34557516?s=80&v=4"},"commit":{"message":"update switch-ethereum-chain and add-ethereum-chain handlers","shortMessageHtmlLink":"update switch-ethereum-chain and add-ethereum-chain handlers"}},{"before":"1ec647e9a6cc375e3e2fbbb43a842e333cbf01c8","after":"c26b26d5b1b8be69533836cf51a676c3a5ab7f9b","ref":"refs/heads/Version-v11.16.0-cherry-pick-revert-depricate-linea-goerli","pushedAt":"2024-05-21T20:01:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"danjm","name":"Dan J Miller","path":"/danjm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7499938?s=80&v=4"},"commit":{"message":"fix (cherry-pick): Delete migration 115 (#24666)\n\nhttps://github.com/MetaMask/metamask-extension/pull/24369 reverted the\ncommit that introduced migration 115. Instead of deleting 115, it\nmodified it. The problem with this is:\n- the migration now does nothing\n- the migration can't just be updated in the future, because after it\nruns once for a user, it will never be run again\n\nWhat we need to do is delete migration 115 and then rename the\nsubsequent migrations to one number lower (and update their contents to\nreflect these new migration numbers. Then, when the reverted changes are\nrestored, the migration can be re-added as the new highest numbered\nmigration.\n\nThis PR makes the changes needed to delete migration 115 over multiple\ncommits, for ease of review. Reviewing this PR is really easy _if_ you\nreview commit by commit (but Github can't easily display the simplicity\nof the changes when they are all together). Below I have briefly\ndescribed each commit and included a screenshot of what you will see if\nyou click the link to look at that commit directly\n\ne7d4cb55230f21782562e0c712e16b513cc8de29 **Deletes** the existing\nmigration 115 files\n![Screenshot from 2024-05-21\n05-03-03](https://github.com/MetaMask/metamask-extension/assets/7499938/f062276d-5fa8-4857-880a-4ae1daefb229)\n\n8d78df3060a4758fd5ea3b61de45863b44315849 **Renames** the existing\nmigration 116 files to migration 115 files\n![Screenshot from 2024-05-21\n05-03-23](https://github.com/MetaMask/metamask-extension/assets/7499938/199e8d94-5101-472a-83b7-13b2d94037b9)\n\n3023d17bb80d8d1137f45ff9ef0d1c3d2e33495b **Renames** the existing\nmigration 117 files to migration 116 files\n![Screenshot from 2024-05-21\n05-03-39](https://github.com/MetaMask/metamask-extension/assets/7499938/7fddc54d-8e0a-44f7-ad14-00cf12041f14)\n\n23f121b53d5bd40c1944f515be9d4b2ce349f753 **Renames** the existing\nmigration 118 files to migration 117 files\n![Screenshot from 2024-05-21\n05-04-15](https://github.com/MetaMask/metamask-extension/assets/7499938/7c97a3aa-7f22-4db2-a7b7-bacbd9fca7b9)\n\nf6cbb92cae17b563fb97e565d511b3cb0da45a11 **Renames** the existing\nmigration 119 files to migration 118 files\n![Screenshot from 2024-05-21\n05-04-28](https://github.com/MetaMask/metamask-extension/assets/7499938/223cc3f9-b3a2-4b42-ae9a-3eba526d8968)\n\nf40afd721ee5d535cb7506b13b17d810c1983426 **Modifies** the renamed files\nfrom the previous commits, so that any number within those files in the\nrange 115-119 is replaced by the number one below.\n![Screenshot from 2024-05-21\n05-05-29](https://github.com/MetaMask/metamask-extension/assets/7499938/3a680ca8-1c30-4e6e-bace-7c8b206cdb7e)\n\n088ecd5e125e90d44f575714836ee7c68ca89df4 Just deletes 1 line from\napp/scripts/migrations/index.js\n\n[![Open in GitHub\nCodespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24666?quickstart=1)\n\n1. Create a local build on the master branch, install and onboard\n2. Create a build on this branch, install\n3. In the background console, you should see logs that show migrations\n115 to 118 running successfully\n\n- [ ] I’ve followed [MetaMask Coding\nStandards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).\n- [ ] I've completed the PR template to the best of my ability\n- [ ] I’ve included tests if applicable\n- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format\nif applicable\n- [ ] I’ve applied the right labels on the PR (see [labeling\nguidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).\nNot required for external contributors.\n\n- [ ] I've manually tested the PR (e.g. pull and build branch, run the\napp, test code being changed).\n- [ ] I confirm that this PR addresses all acceptance criteria described\nin the ticket it closes and includes the necessary testing evidence such\nas recordings and or screenshots.","shortMessageHtmlLink":"fix (cherry-pick): Delete migration 115 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2307566287\" data-permission-text=\"Title is private\" data-url=\"https://github.com/MetaMask/metamask-extension/issues/24666\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/MetaMask/metamask-extension/pull/24666/hovercard\" href=\"https://github.com/MetaMask/metamask-extension/pull/24666\">#24666</a>)"}},{"before":"b40febd2ec9e6792b36bf85d972d1311dbd9f367","after":"9360e51ade10348c3607cea4bc556cf09f8f1ce9","ref":"refs/heads/l10n_crowdin_action","pushedAt":"2024-05-21T19:48:12.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"New Crowdin translations by Github Action","shortMessageHtmlLink":"New Crowdin translations by Github Action"}},{"before":"5d1a276024dfcf9381b95ebb43482610e5d290c9","after":null,"ref":"refs/heads/dbrans/fix-decimals","pushedAt":"2024-05-21T19:47:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dbrans","name":"Derek Brans","path":"/dbrans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/507015?s=80&v=4"}},{"before":"c586d33fec5ba31bb0e32f3288b694572a26c6c4","after":"4233f9ed062e2d84250c45f17e8bb0dd2dafaaab","ref":"refs/heads/develop","pushedAt":"2024-05-21T19:47:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"dbrans","name":"Derek Brans","path":"/dbrans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/507015?s=80&v=4"},"commit":{"message":"fix: stopgap for BigNumber shift NaN issue (#24691)\n\n<!--\r\nPlease submit this PR as a draft initially.\r\nDo not mark it as \"Ready for review\" until the template has been\r\ncompletely filled out, and PR status checks have passed at least once.\r\n-->\r\n\r\n## **Description**\r\nStopgap for https://github.com/MetaMask/metamask-extension/issues/24690\r\n\r\n[![Open in GitHub\r\nCodespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24691?quickstart=1)\r\n\r\n## **Related issues**\r\n\r\nRelated: https://github.com/MetaMask/metamask-extension/issues/24690\r\n– do not close this.\r\n\r\n## **Manual testing steps**\r\n\r\n1. Try to reproduce\r\nhttps://github.com/MetaMask/metamask-extension/issues/24690\r\n\r\n## **Screenshots/Recordings**\r\n\r\n<!-- If applicable, add screenshots and/or recordings to visualize the\r\nbefore and after of your change. -->\r\n\r\n### **Before**\r\n\r\n<!-- [screenshots/recordings] -->\r\n\r\n### **After**\r\n\r\n<!-- [screenshots/recordings] -->\r\n\r\n## **Pre-merge author checklist**\r\n\r\n- [ ] I’ve followed [MetaMask Coding\r\nStandards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).\r\n- [ ] I've completed the PR template to the best of my ability\r\n- [ ] I’ve included tests if applicable\r\n- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format\r\nif applicable\r\n- [ ] I’ve applied the right labels on the PR (see [labeling\r\nguidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).\r\nNot required for external contributors.\r\n\r\n## **Pre-merge reviewer checklist**\r\n\r\n- [ ] I've manually tested the PR (e.g. pull and build branch, run the\r\napp, test code being changed).\r\n- [ ] I confirm that this PR addresses all acceptance criteria described\r\nin the ticket it closes and includes the necessary testing evidence such\r\nas recordings and or screenshots.","shortMessageHtmlLink":"fix: stopgap for BigNumber shift NaN issue (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2308746341\" data-permission-text=\"Title is private\" data-url=\"https://github.com/MetaMask/metamask-extension/issues/24691\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/MetaMask/metamask-extension/pull/24691/hovercard\" href=\"https://github.com/MetaMask/metamask-extension/pull/24691\">#24691</a>)"}},{"before":"06e037ee05328af497a2437a910070a35b645dd2","after":"7e4f7e32f2befe54d105af28d1679067844d4817","ref":"refs/heads/feat/new-metamask-notifications","pushedAt":"2024-05-21T18:27:20.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matteoscurati","name":"Matteo Scurati","path":"/matteoscurati","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1284304?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into feat/new-metamask-notifications","shortMessageHtmlLink":"Merge branch 'develop' into feat/new-metamask-notifications"}},{"before":"f0000a4cc13f03ab9de166c9a414999ed960b4f8","after":null,"ref":"refs/heads/circle-retry","pushedAt":"2024-05-21T18:18:57.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"HowardBraham","name":"Howard Braham","path":"/HowardBraham","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/539738?s=80&v=4"}},{"before":"bd8b7d48a45200480a003457ca5ae61134c7928a","after":"2410a575fffa1a7173d0efdc7a629fc1c4228325","ref":"refs/heads/fix/update-sepolia-nickname-on-signature","pushedAt":"2024-05-21T18:13:27.000Z","pushType":"push","commitsCount":16,"pusher":{"login":"sahar-fehri","name":null,"path":"/sahar-fehri","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10994169?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into fix/update-sepolia-nickname-on-signature","shortMessageHtmlLink":"Merge branch 'develop' into fix/update-sepolia-nickname-on-signature"}},{"before":"0fed9fd87bf71f9bfdf37337dcd1cf6ef9e7330a","after":"b40febd2ec9e6792b36bf85d972d1311dbd9f367","ref":"refs/heads/l10n_crowdin_action","pushedAt":"2024-05-21T18:04:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"New Crowdin translations by Github Action","shortMessageHtmlLink":"New Crowdin translations by Github Action"}},{"before":"adf5e254d05a9ffb4a1ffc1f0515f3087bf6fbed","after":null,"ref":"refs/heads/delete-migration-115","pushedAt":"2024-05-21T18:02:52.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"danjm","name":"Dan J Miller","path":"/danjm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7499938?s=80&v=4"}},{"before":"0ef3c22c260e6682df27fc0a99c38d6275338490","after":"c586d33fec5ba31bb0e32f3288b694572a26c6c4","ref":"refs/heads/develop","pushedAt":"2024-05-21T18:02:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danjm","name":"Dan J Miller","path":"/danjm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7499938?s=80&v=4"},"commit":{"message":"fix: Delete migration 115 (#24666)\n\n## **Description**\r\n\r\nhttps://github.com/MetaMask/metamask-extension/pull/24369 reverted the\r\ncommit that introduced migration 115. Instead of deleting 115, it\r\nmodified it. The problem with this is:\r\n- the migration now does nothing\r\n- the migration can't just be updated in the future, because after it\r\nruns once for a user, it will never be run again\r\n\r\nWhat we need to do is delete migration 115 and then rename the\r\nsubsequent migrations to one number lower (and update their contents to\r\nreflect these new migration numbers. Then, when the reverted changes are\r\nrestored, the migration can be re-added as the new highest numbered\r\nmigration.\r\n\r\nThis PR makes the changes needed to delete migration 115 over multiple\r\ncommits, for ease of review. Reviewing this PR is really easy _if_ you\r\nreview commit by commit (but Github can't easily display the simplicity\r\nof the changes when they are all together). Below I have briefly\r\ndescribed each commit and included a screenshot of what you will see if\r\nyou click the link to look at that commit directly\r\n\r\ne7d4cb55230f21782562e0c712e16b513cc8de29 **Deletes** the existing\r\nmigration 115 files\r\n![Screenshot from 2024-05-21\r\n05-03-03](https://github.com/MetaMask/metamask-extension/assets/7499938/f062276d-5fa8-4857-880a-4ae1daefb229)\r\n\r\n\r\n8d78df3060a4758fd5ea3b61de45863b44315849 **Renames** the existing\r\nmigration 116 files to migration 115 files\r\n![Screenshot from 2024-05-21\r\n05-03-23](https://github.com/MetaMask/metamask-extension/assets/7499938/199e8d94-5101-472a-83b7-13b2d94037b9)\r\n\r\n\r\n3023d17bb80d8d1137f45ff9ef0d1c3d2e33495b **Renames** the existing\r\nmigration 117 files to migration 116 files\r\n![Screenshot from 2024-05-21\r\n05-03-39](https://github.com/MetaMask/metamask-extension/assets/7499938/7fddc54d-8e0a-44f7-ad14-00cf12041f14)\r\n\r\n\r\n23f121b53d5bd40c1944f515be9d4b2ce349f753 **Renames** the existing\r\nmigration 118 files to migration 117 files\r\n![Screenshot from 2024-05-21\r\n05-04-15](https://github.com/MetaMask/metamask-extension/assets/7499938/7c97a3aa-7f22-4db2-a7b7-bacbd9fca7b9)\r\n\r\n\r\nf6cbb92cae17b563fb97e565d511b3cb0da45a11 **Renames** the existing\r\nmigration 119 files to migration 118 files\r\n![Screenshot from 2024-05-21\r\n05-04-28](https://github.com/MetaMask/metamask-extension/assets/7499938/223cc3f9-b3a2-4b42-ae9a-3eba526d8968)\r\n\r\n\r\nf40afd721ee5d535cb7506b13b17d810c1983426 **Modifies** the renamed files\r\nfrom the previous commits, so that any number within those files in the\r\nrange 115-119 is replaced by the number one below.\r\n![Screenshot from 2024-05-21\r\n05-05-29](https://github.com/MetaMask/metamask-extension/assets/7499938/3a680ca8-1c30-4e6e-bace-7c8b206cdb7e)\r\n\r\n088ecd5e125e90d44f575714836ee7c68ca89df4 Just deletes 1 line from\r\napp/scripts/migrations/index.js\r\n\r\n\r\n[![Open in GitHub\r\nCodespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24666?quickstart=1)\r\n\r\n## **Manual testing steps**\r\n\r\n1. Create a local build on the master branch, install and onboard\r\n2. Create a build on this branch, install\r\n3. In the background console, you should see logs that show migrations\r\n115 to 118 running successfully\r\n\r\n## **Pre-merge author checklist**\r\n\r\n- [ ] I’ve followed [MetaMask Coding\r\nStandards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).\r\n- [ ] I've completed the PR template to the best of my ability\r\n- [ ] I’ve included tests if applicable\r\n- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format\r\nif applicable\r\n- [ ] I’ve applied the right labels on the PR (see [labeling\r\nguidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).\r\nNot required for external contributors.\r\n\r\n## **Pre-merge reviewer checklist**\r\n\r\n- [ ] I've manually tested the PR (e.g. pull and build branch, run the\r\napp, test code being changed).\r\n- [ ] I confirm that this PR addresses all acceptance criteria described\r\nin the ticket it closes and includes the necessary testing evidence such\r\nas recordings and or screenshots.","shortMessageHtmlLink":"fix: Delete migration 115 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2307566287\" data-permission-text=\"Title is private\" data-url=\"https://github.com/MetaMask/metamask-extension/issues/24666\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/MetaMask/metamask-extension/pull/24666/hovercard\" href=\"https://github.com/MetaMask/metamask-extension/pull/24666\">#24666</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUFPLsgA","startCursor":null,"endCursor":null}},"title":"Activity · MetaMask/metamask-extension"}