util/text/validate.go: Safe is not safe

[3052]

git-bug/util/text/validate.go

Lines 19 to 34 in 1212f75

	// Safe will tell if a character in the string is considered unsafe
	// Currently trigger on unicode control character except \n, \t and \r
	func Safe(s string) bool {
	for _, r := range s {
	switch r {
	case '\t', '\r', '\n':
	continue
	}
	if unicode.IsControl(r) {
	return false
	}
	}
	return true
	}

doesn't check for invalid UTF-8, so this string would be returned as safe:

"\xA0\xA1"

also doesn't catch all control characters, so this would also be returned as safe:

"\u200E"

improved code:

package unicode

import (
   "unicode"
   "unicode/utf8"
)

func binary(src []byte) bool {
   for len(src) >= 1 {
      r, size := utf8.DecodeRune(src)
      if r == utf8.RuneError {
         if size == 1 {
            return true
         }
      }
      if unicode.Is(unicode.C, r) {
         return true
      }
      src = src[size:]
   }
   return false
}