New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-install script causes failures #1339
Comments
I've been using I wonder if we can just remove the |
@moritonal I've never had this issue. Nevertheless, I suggest you to update PowerShell to a newer version. See https://github.com/PowerShell/PowerShell for more information. |
Yes, you are correct that Powershell 5.1.22000.832 throws an error when running My advice is simply to remove the postinstall script, it's against the OpenCollectives recommendation, leaks data into the host's machine via configstore, and likely has failed on other peoples machines and they simply didn't say anything thinking the package itself is broken. However, I do appreciate it is a revenue stream for you, so of course it's your choice how you handle this. |
I was wondering if we can move |
@carlocorradini What is the benefit of such change? I think I would switch to |
See this from Open Collective. |
@MichalLytek
|
Let's do 1., should be no conflict with the v2.0 branch |
Describe the Bug
When installing the lib on Windows it errors with the line
npm ERR! The token '||' is not a valid statement separator in this version.
.To Reproduce
Install the library.
Expected Behavior
To install correctly.
Cause
The issue is that you have a hacky post-install step in the
package.json
which errors depending on the scripting environment of the installer.Logs
Environment (please complete the following information):
OS: Windows
Node: v16.15.0
Additional Context
This is a pretty clear-cut case of postinstall abuse, but I can work around it with the
--ignore-scripts
flag or a fork. I'd recommend you look at using thenpm fund
process now.The text was updated successfully, but these errors were encountered: