{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":149363030,"defaultBranch":"master","name":"cluster-ingress-operator","ownerLogin":"Miciah","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2018-09-18T23:12:04.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/2042465?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1716536245.0","currentOid":""},"activityList":{"items":[{"before":"2f0e7872151af6cd62bc88ad26403d166f1259c9","after":"3faf391d2d43c63526b256e5f83b163673d8ef9a","ref":"refs/heads/OCPBUGS-23221-internalServiceChanged-fix-target-port-logic","pushedAt":"2024-05-24T08:50:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"copyProbe: Refactor to group copying of defaults\n\n* pkg/operator/controller/ingress/deployment.go (copyProbe): Group together\nthe assignments for the case that copyDefaultValues is true.","shortMessageHtmlLink":"copyProbe: Refactor to group copying of defaults"}},{"before":null,"after":"a4c8bc78eb2e7926dc3738eb3df70006b5467d70","ref":"refs/heads/OCPBUGS-34418-allow-router-pods-to-use-the-restricted-SCC","pushedAt":"2024-05-24T07:37:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Allow router pods to use the \"restricted\" SCC\n\nGive router pods permission to use the \"restricted\"\nsecuritycontextconstraint.  This permission is required\nsince OpenShift 4.11 in order to use the \"restricted\" SCC.\n\nThe OCP 4.11 release notes mention[1] that explicit permission is now\nrequired to use the \"restricted\" SCC:\n\n    The restricted SCC is no longer available to users of new clusters,\n    unless the access is explicitly granted. In clusters originally\n    installed in OpenShift Container Platform 4.10 or earlier, all\n    authenticated users can use the restricted SCC when upgrading to\n    OpenShift Container Platform 4.11 and later.\n\n1. https://docs.openshift.com/container-platform/4.11/release_notes/ocp-4-11-release-notes.html#ocp-4-11-auth-pod-security-admission\n\nRouter pods already have permission to use the \"hostnetwork\" SCC as they\nneeds this SCC when they use the host network.  Because we did not give\nrouter pods permission to use the \"restricted\" SCC, the pods always used\nthe \"hostnetwork\" SCC, even when they did not use the host network.  After\nthis commit, router pods use the \"hostnetwork\" SCC if they use the host\nnetwork, and router pods use the \"restricted\" SCC otherwise.\n\nThis commit fixes OCPBUGS-34418.\n\nhttps://issues.redhat.com/browse/OCPBUGS-34418\n\n* manifests/00-cluster-role.yaml:\n* pkg/manifests/assets/router/cluster-role.yaml: Add permission to use the\n\"restricted\" SCC.","shortMessageHtmlLink":"Allow router pods to use the \"restricted\" SCC"}},{"before":"4d0f52090379819b1b50af60d060d167a1629ba1","after":"2f0e7872151af6cd62bc88ad26403d166f1259c9","ref":"refs/heads/OCPBUGS-23221-internalServiceChanged-fix-target-port-logic","pushedAt":"2024-05-17T10:03:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Specify parameter values for router probes\n\nSet explicit values for the liveness, readiness, and startup probes in the\nrouter deployment's yaml manifest.\n\nPreviously, the router deployment yaml manifest omitted these values when\nthe intended values were equal to the default values.  This meant that the\nAPI server would set the default values for these parameters, and so the\nprobes ultimately ended up with the intended parameter values.  However,\nomitting these values in the yaml manifest also had the unintended\nside-effect of making the operator log bogus diffs for these parameters\nwhenever it updated the deployment.\n\nAfter this commit, the log output for a deployment update has a less noisy\ndiff.\n\n* pkg/manifests/assets/router/deployment.yaml: Specify explicit values for\nthe failureThreshold, httpGet.scheme, periodSeconds, successThreshold, and\ntimeoutSeconds parameters for the liveness, readiness, and startup probes.\n* pkg/operator/controller/ingress/deployment.go (copyProbe): Add a\ncopyDefaultValues parameter.  If this parameter is true, copyProbe will\ncopy the value for a field even if is equal to the default value.\n(hashableProbe): Call copyProbe with copyDefaultValues set to false so that\nempty and default values result in the same hash.\n(deploymentConfigChanged): Call copyProbe with copyDefaultValues set to\ntrue so that default values get copied to the updated object gets diffed\nfor logging.\n* pkg/operator/controller/ingress/deployment_test.go (checkProbes): New\nhelper function to verify that the given container has the expected probes\nand probe parameters.\n(TestDesiredRouterDeploymentSpecAndNetwork):\n(TestDesiredRouterDeploymentVariety): Use checkProbes.","shortMessageHtmlLink":"Specify parameter values for router probes"}},{"before":"b591332b65d3c51df6ff34e26b2cf01f2b7cce09","after":"4d0f52090379819b1b50af60d060d167a1629ba1","ref":"refs/heads/OCPBUGS-23221-internalServiceChanged-fix-target-port-logic","pushedAt":"2024-05-17T06:04:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Specify parameter values for router probes\n\nSet explicit values for the liveness, readiness, and startup probes in the\nrouter deployment's yaml manifest.\n\nPreviously, the router deployment yaml manifest omitted these values when\nthe intended values were equal to the default values.  This meant that the\nAPI server would set the default values for these parameters, and so the\nprobes ultimately ended up with the intended parameter values.  However,\nomitting these values in the yaml manifest also had the unintended\nside-effect of making the operator log bogus diffs for these parameters\nwhenever it updated the deployment.\n\nAfter this commit, the log output for a deployment update has a less noisy\ndiff.\n\n* pkg/manifests/assets/router/deployment.yaml: Specify explicit values for\nthe failureThreshold, httpGet.scheme, periodSeconds, successThreshold, and\ntimeoutSeconds parameters for the liveness, readiness, and startup probes.\n* pkg/operator/controller/ingress/deployment.go (copyProbe): Add a\ncopyDefaultValues parameter.  If this parameter is true, copyProbe will\ncopy the value for a field even if is equal to the default value.\n(hashableProbe): Call copyProbe with copyDefaultValues set to false so that\nempty and default values result in the same hash.\n(deploymentConfigChanged): Call copyProbe with copyDefaultValues set to\ntrue so that default values get copied to the updated object gets diffed\nfor logging.\n* pkg/operator/controller/ingress/deployment_test.go (checkProbes): New\nhelper function to verify that the given container has the expected probes\nand probe parameters.\n(TestDesiredRouterDeploymentSpecAndNetwork):\n(TestDesiredRouterDeploymentVariety): Use checkProbes.","shortMessageHtmlLink":"Specify parameter values for router probes"}},{"before":"7599a46d8ecfee4b398bd5f228aceb1040c2c165","after":"b591332b65d3c51df6ff34e26b2cf01f2b7cce09","ref":"refs/heads/OCPBUGS-23221-internalServiceChanged-fix-target-port-logic","pushedAt":"2024-05-17T03:03:22.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Specify parameter values for router probes\n\nSet explicit values for the liveness, readiness, and startup probes in the\nrouter deployment's yaml manifest.\n\nPreviously, the router deployment yaml manifest omitted these values when\nthe intended values were equal to the default values.  This meant that the\nAPI server would set the default values for these parameters, and so the\nprobes ultimately ended up with the intended parameter values.  However,\nomitting these values in the yaml manifest also had the unintended\nside-effect of making the operator log bogus diffs for these parameters\nwhenever it updated the deployment.\n\nAfter this commit, the log output for a deployment update has a less noisy\ndiff.\n\n* pkg/manifests/assets/router/deployment.yaml: Specify explicit values for\nthe failureThreshold, httpGet.scheme, periodSeconds, successThreshold, and\ntimeoutSeconds parameters for the liveness, readiness, and startup probes.\n* pkg/operator/controller/ingress/deployment_test.go (checkProbes): New\nhelper function to verify that the given container has the expected probes\nand probe parameters.\n(TestDesiredRouterDeploymentSpecAndNetwork):\n(TestDesiredRouterDeploymentVariety): Use checkProbes.","shortMessageHtmlLink":"Specify parameter values for router probes"}},{"before":"cfba4d9ad778d01a6ab874682ad0c2d95f81eab0","after":"7599a46d8ecfee4b398bd5f228aceb1040c2c165","ref":"refs/heads/OCPBUGS-23221-internalServiceChanged-fix-target-port-logic","pushedAt":"2024-05-04T01:05:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"TestHostNetworkPortBinding: Check service ports\n\nUpdate TestHostNetworkPortBinding to verify that the internal service has\nthe expected ports.  In particular, the metrics port should have its target\nport set to the name \"metrics\" rather than a port number.\n\n* test/e2e/operator_test.go (TestHostNetworkPortBinding): Assert that the\ninternal service has the expected ports.","shortMessageHtmlLink":"TestHostNetworkPortBinding: Check service ports"}},{"before":"3d06500a64b02ae95d533bebc03fd4bee019e05b","after":"cfba4d9ad778d01a6ab874682ad0c2d95f81eab0","ref":"refs/heads/OCPBUGS-23221-internalServiceChanged-fix-target-port-logic","pushedAt":"2024-05-03T22:14:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"TestHostNetworkPortBinding: Check service ports\n\nUpdate TestHostNetworkPortBinding to verify that the internal service has\nthe expected ports.  In particular, the metrics port should have its target\nport set to the name \"metrics\" rather than a port number.\n\n* test/e2e/operator_test.go (TestHostNetworkPortBinding): Assert that the\ninternal service has the expected ports.","shortMessageHtmlLink":"TestHostNetworkPortBinding: Check service ports"}},{"before":"3a56b8dbad66a5ca58fdd7d140985872e119c173","after":"3d06500a64b02ae95d533bebc03fd4bee019e05b","ref":"refs/heads/OCPBUGS-23221-internalServiceChanged-fix-target-port-logic","pushedAt":"2024-05-03T22:01:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"TestHostNetworkPortBinding: Check service ports\n\nUpdate TestHostNetworkPortBinding to verify that the internal service has\nthe expected ports.  In particular, the metrics port should have its target\nport set to the name \"metrics\" rather than a port number.\n\n* test/e2e/operator_test.go (TestHostNetworkPortBinding): Assert that the\ninternal service has the expected ports.","shortMessageHtmlLink":"TestHostNetworkPortBinding: Check service ports"}},{"before":"e11e325141b4f4c60ebfb520d26739e83a44326e","after":"3a56b8dbad66a5ca58fdd7d140985872e119c173","ref":"refs/heads/OCPBUGS-23221-internalServiceChanged-fix-target-port-logic","pushedAt":"2024-05-03T21:55:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"TestHostNetworkPortBinding: Check service ports\n\nUpdate TestHostNetworkPortBinding to verify that the internal service has\nthe expected ports.  In particular, the metrics port should have its target\nport set to the name \"metrics\" rather than a port number.\n\n* test/e2e/operator_test.go (TestHostNetworkPortBinding): Assert that the\ninternal service has the expected ports.","shortMessageHtmlLink":"TestHostNetworkPortBinding: Check service ports"}},{"before":"600ed28e6f713ec4fe0d2e94b37061f96bf61852","after":"e11e325141b4f4c60ebfb520d26739e83a44326e","ref":"refs/heads/OCPBUGS-23221-internalServiceChanged-fix-target-port-logic","pushedAt":"2024-05-03T06:28:50.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Test_desiredInternalIngressControllerService: godoc\n\n* pkg/operator/controller/ingress/internal_service_test.go\n(Test_desiredInternalIngressControllerService): Fix capitalization of the\ntest function name in the godoc.","shortMessageHtmlLink":"Test_desiredInternalIngressControllerService: godoc"}},{"before":"584ef427468eac9d8a5a1948e11ae26f673d3114","after":"600ed28e6f713ec4fe0d2e94b37061f96bf61852","ref":"refs/heads/OCPBUGS-23221-internalServiceChanged-fix-target-port-logic","pushedAt":"2024-05-01T23:34:40.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"crdChanged, nodePortServiceChanged: Fix preserves\n\nFix the update logic in crdChanged and nodePortServiceChanged to preserve\nfields that are ignored when checking whether an update is necessary.\n\nFollow-up to commit 4a306cb33d26c30a6bda1a2bef92a6c564b3c3b5,\ncommit dd962af89327b10fbe99947d36f54f50f69e569e,\ncommit 5579aa1b3573a4d9479a924a1ae78688e2105c5c, and\ncommit d7ffd6e7a9cd89805e273b37fff6e6cca6298677.\n\n* pkg/operator/controller/gatewayapi/crds.go (crdChanged): Preserve\nspec.Conversion.\n* pkg/operator/controller/ingress/nodeport_service.go\n(nodePortServiceChanged): Preserve spec.clusterIPs, spec.ipFamilies, and\nspec.ipFamilyPolicy.","shortMessageHtmlLink":"crdChanged, nodePortServiceChanged: Fix preserves"}},{"before":"53baea6f04f80b40128edd4d55cae58e7dd13dc3","after":"584ef427468eac9d8a5a1948e11ae26f673d3114","ref":"refs/heads/OCPBUGS-23221-internalServiceChanged-fix-target-port-logic","pushedAt":"2024-05-01T23:14:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Test_*Changed: Verify that some update was made\n\nThis is a follow-up to the previous commit for consistency.\n\n* pkg/operator/controller/canary/daemonset_test.go\n(Test_canaryDaemonsetChanged):\n* pkg/operator/controller/canary/namespace_test.go\n(Test_canaryNamespaceChanged):\n* pkg/operator/controller/canary/route_test.go\n(Test_canaryRouteChanged):\n* pkg/operator/controller/ingress/deployment_test.go\n(Test_deploymentConfigChanged):\n* pkg/operator/controller/ingress/load_balancer_service_test.go\n(Test_loadBalancerServiceChanged)\n(Test_loadBalancerServiceAnnotationsChanged):\n* pkg/operator/controller/ingress/monitoring_test.go\n(Test_serviceMonitorChanged):\n* pkg/operator/controller/ingress/namespace_test.go\n(Test_routerNamespaceChanged):\n* pkg/operator/controller/ingress/nodeport_service_test.go\n(Test_nodePortServiceChanged):\n* pkg/operator/controller/ingress/poddisruptionbudget_test.go\n(Test_podDisruptionBudgetChange):\n* pkg/operator/controller/ingressclass/ingressclass_test.go\n(Test_ingressClassChanged): Verify that the function made some update to\nthe object if it reported that the object changed.","shortMessageHtmlLink":"Test_*Changed: Verify that some update was made"}},{"before":"b4ea539f657f118edc36ff0ccb6b4cd882e0ddc6","after":"646854cdb75096d8b5435590a6b86df78ba1db2a","ref":"refs/heads/test-config-manager","pushedAt":"2024-05-01T01:09:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Enable config manager by default\n\n* pkg/operator/controller/ingress/deployment.go (desiredRouterDeployment):\nEnable the dynamic config manager by default\n* pkg/operator/controller/ingress/deployment_test.go\n(Test_desiredRouterDeployment): Expect the config manager to be enabled if\nno override is specified.\n* test/e2e/operator_test.go (TestUnsupportedConfigOverride): Explicitly set\noverrides to \"false\" initially rather than assuming that the defaults are\n\"false\".","shortMessageHtmlLink":"Enable config manager by default"}},{"before":"30433aabc66cad7e9e2b93a7c950da6ca39e8d04","after":"53baea6f04f80b40128edd4d55cae58e7dd13dc3","ref":"refs/heads/OCPBUGS-23221-internalServiceChanged-fix-target-port-logic","pushedAt":"2024-05-01T00:53:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Test_*Changed: Verify that some update was made\n\nThis is a follow-up to the previous commit for consistency.\n\n* pkg/operator/controller/canary/daemonset_test.go\n(Test_canaryDaemonsetChanged):\n* pkg/operator/controller/canary/namespace_test.go\n(Test_canaryNamespaceChanged):\n* pkg/operator/controller/canary/route_test.go\n(Test_canaryRouteChanged):\n* pkg/operator/controller/ingress/deployment_test.go\n(Test_deploymentConfigChanged):\n* pkg/operator/controller/ingress/load_balancer_service_test.go\n(Test_loadBalancerServiceChanged)\n(Test_loadBalancerServiceAnnotationsChanged):\n* pkg/operator/controller/ingress/monitoring_test.go\n(Test_serviceMonitorChanged):\n* pkg/operator/controller/ingress/namespace_test.go\n(Test_routerNamespaceChanged):\n* pkg/operator/controller/ingress/nodeport_service_test.go\n(Test_nodePortServiceChanged):\n* pkg/operator/controller/ingress/poddisruptionbudget_test.go\n(Test_podDisruptionBudgetChange):\n* pkg/operator/controller/ingressclass/ingressclass_test.go\n(Test_ingressClassChanged): Verify that the function made some update to\nthe object if it reported that the object changed.","shortMessageHtmlLink":"Test_*Changed: Verify that some update was made"}},{"before":null,"after":"30433aabc66cad7e9e2b93a7c950da6ca39e8d04","ref":"refs/heads/OCPBUGS-23221-internalServiceChanged-fix-target-port-logic","pushedAt":"2024-04-30T19:54:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Test_*Changed: Verify that some update was made\n\nThis is a follow-up to the previous commit for consistency.\n\n* pkg/operator/controller/canary/daemonset_test.go\n(Test_canaryDaemonsetChanged):\n* pkg/operator/controller/canary/namespace_test.go\n(Test_canaryNamespaceChanged):\n* pkg/operator/controller/canary/route_test.go\n(Test_canaryRouteChanged):\n* pkg/operator/controller/ingress/deployment_test.go\n(Test_deploymentConfigChanged):\n* pkg/operator/controller/ingress/load_balancer_service_test.go\n(Test_loadBalancerServiceChanged)\n(Test_loadBalancerServiceAnnotationsChanged):\n* pkg/operator/controller/ingress/monitoring_test.go\n(Test_serviceMonitorChanged):\n* pkg/operator/controller/ingress/namespace_test.go\n(Test_routerNamespaceChanged):\n* pkg/operator/controller/ingress/nodeport_service_test.go\n(Test_nodePortServiceChanged):\n* pkg/operator/controller/ingress/poddisruptionbudget_test.go\n(Test_podDisruptionBudgetChange):\n* pkg/operator/controller/ingressclass/ingressclass_test.go\n(Test_ingressClassChanged): Verify that the function made some update to\nthe object if it reported that the object changed.","shortMessageHtmlLink":"Test_*Changed: Verify that some update was made"}},{"before":"3b4b6bcd3baba3addf5cb41cc920d665dfac7a2b","after":"b4ea539f657f118edc36ff0ccb6b4cd882e0ddc6","ref":"refs/heads/test-config-manager","pushedAt":"2024-04-30T17:17:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Enable config manager by default\n\n* pkg/operator/controller/ingress/deployment.go (desiredRouterDeployment):\nEnable the dynamic config manager by default\n* pkg/operator/controller/ingress/deployment_test.go\n(Test_desiredRouterDeployment): Expect the config manager to be enabled if\nno override is specified.","shortMessageHtmlLink":"Enable config manager by default"}},{"before":null,"after":"f7f09bbe623de8b6e56403cbc07f09c708bce8dc","ref":"refs/heads/OCPBUGS-32942-bump-controller-runtime-to-v0.17.3","pushedAt":"2024-04-25T04:13:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Bump controller-runtime to v0.17.3\n\nBump the vendored sigs.k8s.io/controller-runtime package to v0.17.3, which\nuses the k8s.io/* v0.29.2 packages.\n\n    go get sigs.k8s.io/controller-runtime@v0.17.3\n    go mod tidy\n    go mod vendor\n\nThe v0.17 release of controller-runtime removed NewDiscoveryRESTMapper, and\nso this commit changes cluster-ingress-operator to use NewDynamicRESTMapper\ninstead.\n\nThis commit fixes OCPBUGS-32942.\n\nhttps://issues.redhat.com/browse/OCPBUGS-32942\n\n* go.mod: Bump.\n* go.sum: Regenerate.\n* pkg/operator/client/client.go (NewClient): Update to use\nNewDynamicRESTMapper instead of NewDiscoveryRESTMapper.\n* vendor/*: Regenerate.","shortMessageHtmlLink":"Bump controller-runtime to v0.17.3"}},{"before":null,"after":"f3fe51c5a8712c955840a1c3dc412b8770128d31","ref":"refs/heads/empty-commit","pushedAt":"2024-04-24T19:44:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Empty commit","shortMessageHtmlLink":"Empty commit"}},{"before":null,"after":"77c61bab7abd7be9c7804d66149a8786f4544152","ref":"refs/heads/OCPBUGS-32887-allow-operator-to-update-route-spec.subdomain","pushedAt":"2024-04-24T17:05:18.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Allow operator to update Route spec.subdomain\n\nBefore this commit, cluster-ingress-operator did not have permission to\nupdate spec.host or spec.subdomain on an existing route as the operator's\nserviceaccount did not have the necessary \"routes/custom-host\" permission.\nA previous change to the operator had added logic to clear spec.host and\ninstead set spec.subdomain, but without the required permission, the update\nwould fail with the following error message:\n\n    ERROR   operator.init   controller/controller.go:265    Reconciler error\n{\"controller\": \"canary_controller\", \"object\": {\"name\":\"default\",\"namespace\":\"openshift-ingress-operator\"},\n\"namespace\": \"openshift-ingress-operator\", \"name\": \"default\", \"reconcileID\": \"463061e3-93a1-4067-802e-03e3f1f8cdd0\",\n\"error\": \"failed to ensure canary route: failed to update canary route openshift-ingress-canary/canary:\nRoute.route.openshift.io \\\"canary\\\" is invalid: spec.subdomain: Invalid value: \\\"canary-openshift-ingress-canary\\\": field is immutable\"}\n\nThis commit adds the needed permission to the clusterrole for the\noperator's serviceaccount so that the update can succeed.\n\nThis commit fixes OCPBUGS-32887.\n\nhttps://issues.redhat.com/browse/OCPBUGS-32887\n\nFollow-up to commit 530d326013c9169d1efee77387f33c9ec13108d4.\n\n* manifests/00-cluster-role.yaml: Add permission for routes/custom-host.","shortMessageHtmlLink":"Allow operator to update Route spec.subdomain"}},{"before":"0f316a427665841bc18c2896f34aa35b330c957a","after":"65dcb3f49c7c85f6ac98dd65e679beec2a3198e1","ref":"refs/heads/bump-openshift-slash-api-and-update-CRD-generation","pushedAt":"2024-04-17T17:09:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Bump openshift/api, and update CRD generation\n\nBump to github.com/openshift/api@ff84c2c732279b16baccf08c7dfc9ff8719c4807,\nand update the CRD generation to adapt to changes in openshift/api:\n\n    go mod edit -replace=github.com/openshift/api=github.com/openshift/api@ff84c2c732279b16baccf08c7dfc9ff8719c4807\n    go mod tidy\n    go mod vendor\n    make update\n\nPreviously, the IngressController and DNSRecord CRD yaml manifests were\nlocated directly under operator/v1/ and operatoringress/v1/ in the\nopenshift/api repository, and cluster-ingress-operator had .go files\nthat imported the \"github.com/openshift/api/operator/v1\" and\n\"github.com/openshift/api/operatoringress/v1\" packages, which caused go\nmod to vendor the yaml manifests.  Recent changes in openshift/api moved\nthe yaml manifests under \"zz_generated.crd-manifests\" directories;\nconsequently, the existing import statements no longer cause go mod to\nvendor the yaml manifests.  In order to ensure that go mod does vendor\nthem, it is necessary to add explicit import statements for\n\"github.com/openshift/api/operator/v1/zz_generated.crd-manifests\" and\n\"github.com/openshift/api/operatoringress/v1/zz_generated.crd-manifests\".\nThis commit adds these import statements to tools/tool.go (which was\npreviously removed in commit 0b761da27783b909dd736bfb7c1ee7d822adb004).\n\nThis commit also updates the CRD generation scripts to use the new\nfile paths under vendor/.\n\nThis commit fixes OCPBUGS-32371.\n\nhttps://issues.redhat.com/browse/OCPBUGS-32371\n\n* go.mod: Bump.\n* hack/update-generated-crd.sh:\n* hack/verify-generated-crd.sh: Update to use the new file paths under\nvendor/.\n* tools/tools.go: Add explicit imports for\n\"github.com/openshift/api/operator/v1/zz_generated.crd-manifests\" and\n\"github.com/openshift/api/operatoringress/v1/zz_generated.crd-manifests\".\n* go.sum:\n* manifests/00-custom-resource-definition-internal.yaml:\n* manifests/00-custom-resource-definition.yaml:\n* vendor/*: Regenerate.","shortMessageHtmlLink":"Bump openshift/api, and update CRD generation"}},{"before":"0471dbb3a254824524405a36a599c69ac09cbbf9","after":"0f316a427665841bc18c2896f34aa35b330c957a","ref":"refs/heads/bump-openshift-slash-api-and-update-CRD-generation","pushedAt":"2024-04-17T16:29:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Bump openshift/api, and update CRD generation\n\nBump to github.com/openshift/api@ff84c2c732279b16baccf08c7dfc9ff8719c4807,\nand update the CRD generation to adapt to changes in openshift/api:\n\n    go mod edit -replace=github.com/openshift/api=github.com/openshift/api@ff84c2c732279b16baccf08c7dfc9ff8719c4807\n    go mod tidy\n    go mod vendor\n    make update\n\nPreviously, the IngressController and DNSRecord CRD yaml manifests were\nlocated directly under operator/v1/ and operatoringress/v1/ in the\nopenshift/api repository, and cluster-ingress-operator had .go files\nthat imported the \"github.com/openshift/api/operator/v1\" and\n\"github.com/openshift/api/operatoringress/v1\" packages, which caused go\nmod to vendor the yaml manifests.  Recent changes in openshift/api moved\nthe yaml manifests under \"zz_generated.crd-manifests\" directories;\nconsequently, the existing import statements no longer cause go mod to\nvendor the yaml manifests.  In order to ensure that go mod does vendor\nthem, it is necessary to add explicit import statements for\n\"github.com/openshift/api/operator/v1/zz_generated.crd-manifests\" and\n\"github.com/openshift/api/operatoringress/v1/zz_generated.crd-manifests\".\nThis commit adds these import statements to tools/tool.go (which was\npreviously removed in commit 0b761da27783b909dd736bfb7c1ee7d822adb004).\n\nThis commit also updates the CRD generation scripts to use the new\nfile paths under vendor/.\n\n* go.mod: Bump.\n* hack/update-generated-crd.sh:\n* hack/verify-generated-crd.sh: Update to use the new file paths under\nvendor/.\n* tools/tools.go: Add explicit imports for\n\"github.com/openshift/api/operator/v1/zz_generated.crd-manifests\" and\n\"github.com/openshift/api/operatoringress/v1/zz_generated.crd-manifests\".\n* go.sum:\n* manifests/00-custom-resource-definition-internal.yaml:\n* manifests/00-custom-resource-definition.yaml:\n* vendor/*: Regenerate.","shortMessageHtmlLink":"Bump openshift/api, and update CRD generation"}},{"before":"fab6fe65286c74513a7c201c90395c5f7c9a8e32","after":"0471dbb3a254824524405a36a599c69ac09cbbf9","ref":"refs/heads/bump-openshift-slash-api-and-update-CRD-generation","pushedAt":"2024-04-17T16:28:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Bump openshift/api, and update CRD generation\n\nBump to github.com/openshift/api@ff84c2c732279b16baccf08c7dfc9ff8719c4807,\nand update the CRD generation to adapt to changes in openshift/api:\n\n    go mod edit -replace=github.com/openshift/api=github.com/openshift/api@ff84c2c732279b16baccf08c7dfc9ff8719c4807\n    go mod tidy\n    go mod vendor\n    make update\n\nPreviously, the IngressController and DNSRecord CRD yaml manifests were\nlocated directly under operator/v1/ and operatoringress/v1/ in the\nopenshift/api repository, and cluster-ingress-operator had .go files\nthat imported the \"github.com/openshift/api/operator/v1\" and\n\"github.com/openshift/api/operatoringress/v1\" packages, which caused go\nmod to vendor the yaml manifests.  Recent changes in openshift/api moved\nthe yaml manifests under \"zz_generated.crd-manifests\" directories;\nconsequently, the existing import statements no longer cause go mod to\nvendor the yaml manifests.  In order to ensure that go mod does vendor\nthem, it is necessary to add explicit import statements for\n\"github.com/openshift/api/operator/v1/zz_generated.crd-manifests\" and\n\"github.com/openshift/api/operatoringress/v1/zz_generated.crd-manifests\".\nThis commit adds these import statements to tools/tool.go (which was\npreviously removed in commit 0b761da27783b909dd736bfb7c1ee7d822adb004).\n\nThis commit also updates the CRD generation scripts to use the new\nfile paths under vendor/.\n\n* go.mod: Bump.\n* hack/update-generated-crd.sh:\n* hack/verify-generated-crd.sh: Update to use the new file paths under\nvendor/.\n* tools/tools.go: Add explicit imports for\n\"github.com/openshift/api/operator/v1/zz_generated.crd-manifests\" and\n\"github.com/openshift/api/operatoringress/v1/zz_generated.crd-manifests\".\n* go.sum:\n* manifests/00-custom-resource-definition-internal.yaml:\n* manifests/00-custom-resource-definition.yaml\n* vendor/*: Regenerate.","shortMessageHtmlLink":"Bump openshift/api, and update CRD generation"}},{"before":"4d8c89709de21188985e106cbbde0892e3cbcdc0","after":"fab6fe65286c74513a7c201c90395c5f7c9a8e32","ref":"refs/heads/bump-openshift-slash-api-and-update-CRD-generation","pushedAt":"2024-03-27T01:46:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Bump openshift/api, and update CRD generation\n\nBump to github.com/openshift/api@ff84c2c732279b16baccf08c7dfc9ff8719c4807,\nand update the CRD generation to adapt to changes in openshift/api:\n\n    go mod edit -replace=github.com/openshift/api=github.com/openshift/api@ff84c2c732279b16baccf08c7dfc9ff8719c4807\n    go mod tidy\n    go mod vendor\n    make update\n\nPreviously, the IngressController and DNSRecord CRD yaml manifests were\nlocated directly under operator/v1/ and operatoringress/v1/ in the\nopenshift/api repository, and cluster-ingress-operator had .go files\nthat imported the \"github.com/openshift/api/operator/v1\" and\n\"github.com/openshift/api/operatoringress/v1\" packages, which caused go\nmod to vendor the yaml manifests.  Recent changes in openshift/api moved\nthe yaml manifests under \"zz_generated.crd-manifests\" directories;\nconsequently, the existing import statements no longer cause go mod to\nvendor the yaml manifests.  In order to ensure that go mod does vendor\nthem, it is necessary to add explicit import statements for\n\"github.com/openshift/api/operator/v1/zz_generated.crd-manifests\" and\n\"github.com/openshift/api/operatoringress/v1/zz_generated.crd-manifests\".\nThis commit adds these import statements to tools/tool.go (which was\npreviously removed in commit 0b761da27783b909dd736bfb7c1ee7d822adb004).\n\nThis commit also updates the CRD generation scripts to use the new\nfile paths under vendor/.\n\n* go.mod: Bump.\n* hack/update-generated-crd.sh:\n* hack/verify-generated-crd.sh: Update to use the new file paths under\nvendor/.\n* tools/tools.go: Add explicit imports for\n\"github.com/openshift/api/operator/v1/zz_generated.crd-manifests\" and\n\"github.com/openshift/api/operatoringress/v1/zz_generated.crd-manifests\".\n* go.sum:\n* manifests/00-custom-resource-definition-internal.yaml:\n* manifests/00-custom-resource-definition.yaml\n* vendor/*: Regenerate.","shortMessageHtmlLink":"Bump openshift/api, and update CRD generation"}},{"before":null,"after":"4d8c89709de21188985e106cbbde0892e3cbcdc0","ref":"refs/heads/bump-openshift-slash-api-and-update-CRD-generation","pushedAt":"2024-03-27T01:41:42.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Bump openshift/api, and update CRD generation\n\nBump to github.com/openshift/api@ff84c2c732279b16baccf08c7dfc9ff8719c4807,\nand update the CRD generation to adapt to changes in openshift/api.\n\nPreviously, the IngressController and DNSRecord CRD yaml manifests were\nlocated directly under operator/v1/ and operatoringress/v1/ in the\nopenshift/api repository, and cluster-ingress-operator had .go files\nthat imported the \"github.com/openshift/api/operator/v1\" and\n\"github.com/openshift/api/operatoringress/v1\" packages, which caused go\nmod to vendor the yaml manifests.  Recent changes in openshift/api moved\nthe yaml manifests under \"zz_generated.crd-manifests\" directories;\nconsequently, the existing import statements no longer cause go mod to\nvendor the yaml manifests.  In order to ensure that go mod does vendor\nthem, it is necessary to add explicit import statements for\n\"github.com/openshift/api/operator/v1/zz_generated.crd-manifests\" and\n\"github.com/openshift/api/operatoringress/v1/zz_generated.crd-manifests\".\nThis commit adds these import statements to tools/tool.go (which was\npreviously removed in commit 0b761da27783b909dd736bfb7c1ee7d822adb004).\n\nThis commit also updates the CRD generation scripts to use the new\nfile paths under vendor/.\n\n* go.mod: Bump.\n* hack/update-generated-crd.sh:\n* hack/verify-generated-crd.sh: Update to use the new file paths under\nvendor/.\n* tools/tools.go: Add explicit imports for\n\"github.com/openshift/api/operator/v1/zz_generated.crd-manifests\" and\n\"github.com/openshift/api/operatoringress/v1/zz_generated.crd-manifests\".\n* go.sum:\n* manifests/00-custom-resource-definition-internal.yaml:\n* manifests/00-custom-resource-definition.yaml\n* vendor/*: Regenerate.","shortMessageHtmlLink":"Bump openshift/api, and update CRD generation"}},{"before":null,"after":"032983dc33a7da41a5453c739ada87eac08d62d4","ref":"refs/heads/OCPBUGS-30091-TestHostNetworkPortBinding-delete-t-dot-Parallel-call","pushedAt":"2024-02-29T16:42:03.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"TestHostNetworkPortBinding: Delete t.Parallel()\n\nRemove the t.Parallel() call inside TestHostNetworkPortBinding.  The test\nis listed in TestAll as a serial test, but the test itself calls\nt.Parallel(), which causes it to run in parallel with other serial tests.\nThis likely causes occasional failures of the test in CI.\n\nThis commit fixes OCPBUGS-30091.\n\nhttps://issues.redhat.com/browse/OCPBUGS-30091\n\n* test/e2e/operator_test.go (TestHostNetworkPortBinding): Remove\nt.Parallel().","shortMessageHtmlLink":"TestHostNetworkPortBinding: Delete t.Parallel()"}},{"before":null,"after":"0fce1e87c457929238288c4e166625f5da10d802","ref":"refs/heads/remove-http-port-80-from-LB-service","pushedAt":"2024-01-31T13:57:05.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Remove http port 80 from LB service\n\n* pkg/manifests/assets/router/service-cloud.yaml: Remove http port.","shortMessageHtmlLink":"Remove http port 80 from LB service"}},{"before":null,"after":"9a8d6db3976462a586fa58dcf1967cc521a0896a","ref":"refs/heads/cherry-pick-844-to-release-4.15","pushedAt":"2024-01-09T16:24:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Replace GCP role with explicit permissions\n\nInstead of using a predefined role in the cloud credentials request for\nGCP, enumerate permissions explicitly.\n\nThe Google Cloud DNS API permissions are documented here:\n<https://cloud.google.com/dns/docs/access-control>\n\nEach method in the Cloud DNS API has a corresponding permission.  The\noperator's DNS provider implementation for GCP only calls two methods:\n\n- dns.changes.create\n- dns.resourcerecordsets.list\n\nThese methods require the following permissions:\n\n- dns.changes.create\n- dns.resourceRecordSets.create\n- dns.resourceRecordSets.update\n- dns.resourceRecordSets.delete\n- dns.resourceRecordSets.list\n\nThis commit replaces the dns.admin role with these permissions in the\ncredentials request.\n\nThis commit resolves CCO-249.\n\nhttps://issues.redhat.com/browse/CCO-249\n\n* manifests/00-ingress-credentials-request.yaml: Replace the\nroles/dns.admin predefined role with an explicit list of permissions.","shortMessageHtmlLink":"Replace GCP role with explicit permissions"}},{"before":null,"after":"be5c3ae26f57a4ab5afee450d1895a5f2a8239fc","ref":"refs/heads/OCPBUGS-23742-bump-controller-runtime-to-v0.16.3","pushedAt":"2023-11-28T00:39:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Bump controller-runtime to v0.16.3\n\nBump the vendored sigs.k8s.io/controller-runtime package to v0.16.3, the\nlatest release, which uses the k8s.io/* v0.28.3 packages.\n\n    go get sigs.k8s.io/controller-runtime@v0.16.3\n    go mod tidy\n    go mod vendor\n\nThis commit fixes OCPBUGS-23742.\n\nhttps://issues.redhat.com/browse/OCPBUGS-23742\n\n* go.mod: Bump.\n* go.sum: Regenerate.\n* pkg/operator/operator.go (New): Update to use the new DefaultNamespaces\nfield instead of Namespaces, which has been removed from the manager\noptions.\n* pkg/operator/controller/dns/controller_test.go (Test_customCABundle):\nUpdate to use NewClientBuilder instead of NewFakeClientWithScheme, which\nhas been removed from controller-runtime.\n* vendor/*: Regenerate.","shortMessageHtmlLink":"Bump controller-runtime to v0.16.3"}},{"before":"677106add8193aa25183a91559ce25ae56b44c1b","after":"a23682296947cb320cb0094110c6c1cf307e6240","ref":"refs/heads/CCO-249-replace-GCP-role-with-explicit-permissions","pushedAt":"2023-11-07T06:20:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Replace GCP role with explicit permissions\n\nInstead of using a predefined role in the cloud credentials request for\nGCP, enumerate permissions explicitly.\n\nThe Google Cloud DNS API permissions are documented here:\n<https://cloud.google.com/dns/docs/access-control>\n\nEach method in the Cloud DNS API has a corresponding permission.  The\noperator's DNS provider implementation for GCP only calls two methods:\n\n- dns.changes.create\n- dns.resourcerecordsets.list\n\nThese methods require the following permissions:\n\n- dns.changes.create\n- dns.resourceRecordSets.create\n- dns.resourceRecordSets.update\n- dns.resourceRecordSets.delete\n- dns.resourceRecordSets.list\n\nThis commit replaces the dns.admin role with these permissions in the\ncredentials request.\n\nThis commit resolves CCO-249.\n\nhttps://issues.redhat.com/browse/CCO-249\n\n* manifests/00-ingress-credentials-request.yaml: Replace the\nroles/dns.admin predefined role with an explicit list of permissions.","shortMessageHtmlLink":"Replace GCP role with explicit permissions"}},{"before":"a23682296947cb320cb0094110c6c1cf307e6240","after":"677106add8193aa25183a91559ce25ae56b44c1b","ref":"refs/heads/CCO-249-replace-GCP-role-with-explicit-permissions","pushedAt":"2023-11-07T06:20:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Miciah","name":"Miciah Dashiel Butler Masters","path":"/Miciah","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2042465?s=80&v=4"},"commit":{"message":"Replace GCP role with explicit permissions\n\nInstead of using a predefined role in the cloud credentials request for\nGCP, enumerate permissions explicitly.\n\nThe Google Cloud DNS API permissions are documented here:\n<https://cloud.google.com/dns/docs/access-control>\n\nEach method in the Cloud DNS API has a corresponding permission.  The\noperator's DNS provider implementation for GCP only calls two methods:\n\n- dns.changes.create\n- dns.resourcerecordsets.list\n\nThese methods require the following permissions:\n\n- dns.changes.create\n- dns.resourceRecordSets.create\n- dns.resourceRecordSets.update\n- dns.resourceRecordSets.delete\n- dns.resourceRecordSets.list\n\nThis commit replaces the dns.admin role with these permissions in the\ncredentials request.\n\nThis commit resolves CCO-249.\n\nhttps://issues.redhat.com/browse/CCO-249\n\n* manifests/00-ingress-credentials-request.yaml: Replace the\nroles/dns.admin predefined role with an explicit list of permissions.\n* pkg/manifests/bindata.go: Regenerate.","shortMessageHtmlLink":"Replace GCP role with explicit permissions"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUtUYbQA","startCursor":null,"endCursor":null}},"title":"Activity · Miciah/cluster-ingress-operator"}