Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the license to all jar files #191

Merged
merged 1 commit into from Nov 18, 2021

Conversation

bespaltovyj
Copy link
Contributor

@bespaltovyj bespaltovyj commented Nov 4, 2021

Issue #188

Comments for solutions:

  1. I removed all apply because plugins are already applied in plugins sections
  2. There are 2 Jar tasks in the gradle:
    • org.gradle.jvm.tasks.Jar
    • org.gradle.api.tasks.bundling.Jar is subtype of org.gradle.jvm.tasks.Jar.
      In build.gradle.kts by default using org.gradle.api.tasks.bundling.Jar, but Kotlin multiplatform register sourcesJar task with type org.gradle.jvm.tasks.Jar.

So I added import org.gradle.jvm.tasks.Jar to add a license to all jar tasks.

@bespaltovyj bespaltovyj changed the title #188 added the license to all jar files added the license to all jar files Nov 4, 2021
@oshai oshai merged commit e9cced0 into oshai:master Nov 18, 2021
@oshai
Copy link
Owner

oshai commented Nov 18, 2021

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants