Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatic-Module-Name manifest entry #223

Closed
ascopes opened this issue Jan 22, 2022 · 4 comments
Closed

Add Automatic-Module-Name manifest entry #223

ascopes opened this issue Jan 22, 2022 · 4 comments

Comments

@ascopes
Copy link

ascopes commented Jan 22, 2022

On Java 9 or above, in projects using JPMS modules, Maven will currently raise the following warning due to kotlin-logging not having the Automatic-Module-Name manifest entry:

[WARNING] *****************************************************************************************************************************************************
[WARNING] * Required filename-based automodules detected: [kotlin-logging-jvm-2.1.21.jar]. Please don't publish this project to a public artifact repository! *
[WARNING] *****************************************************************************************************************************************************

Would it be possible to push a release that has this MANIFEST entry set explicitly to avoid this issue? This reduces the likelihood of things breaking if build settings change between versions for those who are using Kotlin within a modular Java application.

I am not very savvy on Gradle, which is why I haven't put a PR up myself for this, but the Maven equivalent of this fix would be just specifying the following when producing the JAR:

<archive>
  <manifestEntries>
    <Automatic-Module-Name>io.github.microutils.kotlinlogging</Automatic-Module-Name>
  </manifestEntries>
</archive>

or similar.

Thanks

@github-actions
Copy link

Thank you for reporting an issue. See the wiki for documentation and slack for questions.

@oshai
Copy link
Owner

oshai commented Oct 29, 2022

oshai added a commit that referenced this issue Oct 29, 2022
oshai added a commit that referenced this issue Oct 29, 2022
@oshai
Copy link
Owner

oshai commented Oct 29, 2022

Add in 3.0.3. please let me know if the issue is resolved.

@ascopes
Copy link
Author

ascopes commented Nov 19, 2022

Looks to be good to go. Thanks :)

@ascopes ascopes closed this as completed Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants