Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword slf4j references in README #229

Closed
sschuberth opened this issue May 5, 2022 · 7 comments
Closed

Reword slf4j references in README #229

sschuberth opened this issue May 5, 2022 · 7 comments

Comments

@sschuberth
Copy link

sschuberth commented May 5, 2022

The README refers to slf4j in several places, which reads as if kotlin-logging would work for the the JVM target only. But to my understanding Kotlin multi-platform support has been added some time ago. So it should be made more clear in the README that more targets than JVM are supported.

@github-actions
Copy link

github-actions bot commented May 5, 2022

Thank you for reporting an issue. See the wiki for documentation and slack for questions.

@oshai
Copy link
Owner

oshai commented Jun 9, 2022

the wiki has this section: https://github.com/MicroUtils/kotlin-logging/wiki/Multiplatform-support

We can add a link to it on the readme.

@sschuberth
Copy link
Author

We can add a link to it on the readme.

Thanks for the offer, but my main point is not about adding more information, but removing outdated / wrong information. Having that link in addition to the slf4j references would be even more confusing, IMO.

@oshai
Copy link
Owner

oshai commented Jun 9, 2022

Would you like to create a pr with the suggestion?

@sschuberth
Copy link
Author

While the changes are probably not many lines of code, I'm quite uncertain which parts of the docs are still wanted to refer to slf4j (e.g. for historical reasons), and which not, so I'd rather leave this to someone familiar with the project.

oshai added a commit that referenced this issue Oct 29, 2022
@oshai
Copy link
Owner

oshai commented Oct 29, 2022

Created PR #255 for it.

oshai added a commit that referenced this issue Oct 29, 2022
@sschuberth
Copy link
Author

Created PR #255 for it.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants