Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Azure SDK Patching Subscriber #562

Merged
merged 28 commits into from Jun 18, 2020
Merged

feat: add Azure SDK Patching Subscriber #562

merged 28 commits into from Jun 18, 2020

Conversation

markwolff
Copy link
Contributor

  • Adds subscriber for new azure SDK tracer patching
  • Changes functional tests to use W3C header propagation
  • Add AzureSDK functional test
  • Support nested propagation testing in functional test suite

markwolff
markwolff commented Nov 1, 2019
View reviewed changes
AutoCollection/AsyncHooksScopeManager.ts
import { ISpanContext } from "diagnostic-channel";
import { EventEmitter } from "events";

export interface Span {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A clone of Span interface so that we don't need to take a Typescript 3 dependency

markwolff
markwolff commented Nov 1, 2019
View reviewed changes
AutoCollection/diagnostic-channel/azure-coretracing.sub.ts Outdated
Comment on lines 49 to 50
data: span.attributes.component || span.name,
dependencyTypeName: span.attributes.component || span.name,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The span attributes aren't guaranteed to provide meaningful information in a standardized way right now, so for now just populate them with current "standards" and iterate back on this in the future

hectorhdzg
hectorhdzg reviewed Nov 1, 2019
View reviewed changes
AutoCollection/diagnostic-channel/azure-coretracing.sub.ts Outdated
}
AsyncScopeManager.with(span, () => {
clients.forEach((client) => {
if (span.kind === 1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enum for SpanKind would be good here

@markwolff markwolff self-assigned this Nov 1, 2019
@markwolff markwolff modified the milestones: 1.6.0, 1.7.0 Nov 7, 2019
@markwolff markwolff modified the milestones: 1.7.0, 1.8.0 Mar 11, 2020
@markwolff markwolff merged commit 162d731 into develop Jun 18, 2020
@markwolff markwolff deleted the markwolff/add-azuresdk-patching branch June 18, 2020 19:19
@hectorhdzg hectorhdzg mentioned this pull request Feb 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorhdzg hectorhdzg hectorhdzg approved these changes

@OsvaldoRosado OsvaldoRosado Awaiting requested review from OsvaldoRosado

@ramthi ramthi Awaiting requested review from ramthi

Assignees

@markwolff markwolff

Labels
None yet
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markwolff @hectorhdzg