fix: dependency name could be null #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorhdzg
reviewed
Feb 26, 2020
| @@ -115,7 +115,9 @@ class EnvelopeFactory { | |||
|
|
|||
| private static createDependencyData(telemetry: Contracts.DependencyTelemetry & Contracts.Identified): Contracts.Data<Contracts.RemoteDependencyData> { | |||
| var remoteDependency = new Contracts.RemoteDependencyData(); | |||
| remoteDependency.name = telemetry.name.length > 1024 ? telemetry.name.slice(0, 1021) + '...' : telemetry.name; | |||
| if (typeof telemetry.name === "string") { | |||
There was a problem hiding this comment.
When null you will not send a name, is this not causing issues during ingestion?, maybe having default empty string?
There was a problem hiding this comment.
Name is not required for ingestion. Really the typings are wrong, but they are autogenerated from the bond files and so I would like to avoid creating discrepancies across language SDKs by making a one-off change for our types
hectorhdzg
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #594