Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only create qps client when live metrics is enabled #613

Merged
merged 1 commit into from Apr 9, 2020

Conversation

markwolff
Copy link
Contributor

fixes #612

@markwolff markwolff merged commit 156036c into develop Apr 9, 2020
@markwolff markwolff deleted the markwolff/skip-qps-creation branch April 9, 2020 17:46
@leidegre
Copy link

leidegre commented Apr 10, 2020

I would like to add that I think it it important that you include that this change actually fixes an actual memory leak.

This leak took down our production environment and caused an outage for about 2 hours. I spent the last week trying to root cause the issue and all that I did to deserve this was that I used the default config as per the examples given for the package.

Now that it has been fixed, it is less likely that newcomers will run into this problem but every system out there, that is running the older code, and using the example as a starting point is leaking memory in such a way that the system will degrade to a point where it will run out of memory completely and fail. I think it deserves some kind of special mention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible memory leak
3 participants