Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions auto collector promise handling #618

Merged
merged 2 commits into from Apr 27, 2020
Merged

Fix exceptions auto collector promise handling #618

merged 2 commits into from Apr 27, 2020

Conversation

MrVarens
Copy link
Contributor

@MrVarens MrVarens commented Apr 21, 2020

All errors thrown from Promises are always send to Application Insights with message [object Promise].

Problem exists because during binding of promise handler only one param is given instead of 2 thats why error value land in name variable.

Code that can be used to reproduce problem:

new Promise<any>(() => {
      throw new Error('test');
});

@MrVarens MrVarens changed the title Fix exception auto collector incorrectly handling promise exceptions Fix exceptions auto collector promise handling Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants